Project structure: FeatureExt#1
Open
Joseph-Bineesh wants to merge 20 commits into
Open
Conversation
Added first two common files from lsp4jakarta and lsp4mp for migration to feature-ext
…dtls.featureext into development
Co-authored by IBM Bob
Rejoice472
reviewed
May 20, 2026
| private String id; | ||
|
|
||
| public CodeActionData() { | ||
| this(null); |
There was a problem hiding this comment.
Improve as in? This is a common file between 2 repos, so as of now, we are not intending to change the content of them, because migration itself would incur lot of changes.
There was a problem hiding this comment.
Add JavaDoc explaining this is shared code between repos and intentionally kept unchanged for migration purposes.
venmanyarun
suggested changes
Jun 5, 2026
| Export-Package: org.eclipse.jdtls.featureext.core, | ||
| org.eclipse.jdtls.featureext.core.logging, | ||
| org.eclipse.jdtls.featureext.commons.codeaction | ||
| Automatic-Module-Name: org.eclipse.jdtls.featureext.core |
There was a problem hiding this comment.
Dont we need
Require-Bundle: org.eclipse.core.runtime,
org.eclipse.jdt.core,
org.eclipse.jdt.ls.core
here?
Author
There was a problem hiding this comment.
This can be add when we use it in the code base.
| @@ -0,0 +1,270 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2024 Eclipse Foundation and others. | |||
| @@ -0,0 +1,45 @@ | |||
| ############################################################################### | |||
| # Copyright (c) 2024 Eclipse Foundation and others. | |||
| @@ -0,0 +1,9 @@ | |||
| /** | |||
| * Core package for JDT.LS feature extensions. | |||
There was a problem hiding this comment.
Should we add copyright for this class?
| @@ -0,0 +1,16 @@ | |||
| ############################################################################### | |||
| # Copyright (c) 2024 Eclipse Foundation and others. | |||
| @@ -0,0 +1,334 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2024 Eclipse Foundation and others. | |||
| private String id; | ||
|
|
||
| public CodeActionData() { | ||
| this(null); |
There was a problem hiding this comment.
Add JavaDoc explaining this is shared code between repos and intentionally kept unchanged for migration purposes.
| public class FeatureExtLogger { | ||
|
|
||
| private static final String LOGGER_NAME = "org.eclipse.jdtls.featureext"; | ||
| private static final Logger LOGGER = Logger.getLogger(LOGGER_NAME); |
There was a problem hiding this comment.
I read somewhere that using org.eclipse.core.runtime.ILog is better Eclipse integration instead of JUL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.