Support Maven <exclusions> syntax within target <dependency> elements#2170
Open
vogella wants to merge 1 commit into
Open
Support Maven <exclusions> syntax within target <dependency> elements#2170vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
Test Results 336 files ± 0 336 suites ±0 1h 3m 24s ⏱️ - 7m 6s For more details on these failures and errors, see this check. Results for commit 21c6ca4. ± Comparison against base commit 98b66b5. |
Member
|
I'm missing UI integration for this feature through the target location editor and the dependency tree. Additionally we already have a way to exclude dependencies, so one would expect this code path to be enhanced instead of adding a complete new codepath. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286
The m2-pde target location now accepts the standard Maven
<exclusions>/<exclusion>syntax inside each<dependency>element, in addition to the existing location-level<exclude>elements.Exclusions are per-dependency (not global) and are applied during transitive dependency collection via
MavenDependencyCollector, consistent with standard Maven semantics. The*wildcard is supported for groupId and artifactId. The format round-trips correctly throughserialize()/parse.