Skip to content

fix(Rate limit): using servlet decoded path over request URI - #1822

Merged
netomi merged 4 commits into
eclipse-openvsx:mainfrom
gnugomez:gnugomez/main/use-decoded-path
May 8, 2026
Merged

fix(Rate limit): using servlet decoded path over request URI#1822
netomi merged 4 commits into
eclipse-openvsx:mainfrom
gnugomez:gnugomez/main/use-decoded-path

Conversation

@gnugomez

@gnugomez gnugomez commented May 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@gnugomez
gnugomez requested a review from netomi May 7, 2026 11:01
@netomi

netomi commented May 8, 2026

Copy link
Copy Markdown
Contributor

the tests fail with weird OutOfMemory exceptions, maybe we should move the new integration tests to the existing class. Running them locally works though for me.

@netomi
netomi force-pushed the gnugomez/main/use-decoded-path branch from e0f1466 to 4711122 Compare May 8, 2026 07:04
@gnugomez

gnugomez commented May 8, 2026

Copy link
Copy Markdown
Member Author

@netomi yeah, I've seen that, can't we increase the limit? would it be a big deal?

I think it's worth having some integration tests for all the rate limit feature separated from the other ones.

@netomi
netomi merged commit 9787ba1 into eclipse-openvsx:main May 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants