Skip to content

fix: exclude displayName check in package.json validation #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
netomi merged 1 commit into from
May 11, 2026
Merged

fix: exclude displayName check in package.json validation #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions server/src/main/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,11 @@ private void validatePackageMetadata(
throw new ErrorResultException("Extension version in extension.vsixmanifest and package.json does not match.");
}

if (!Strings.CI.equals(extVersion.getDisplayName(), packageMetadata.displayName())) {
throw new ErrorResultException("Display name in extension.vsixmanifest and package.json does not match.");
}
// Do not check if the displayName property is equal as it is not fully understood yet how VS Code / vsce processes
// that property. There are some projects, where the value is `%displayName%` and publication will fail.
// if (!Strings.CI.equals(extVersion.getDisplayName(), packageMetadata.displayName())) {
// throw new ErrorResultException("Display name in extension.vsixmanifest and package.json does not match.");
// }
}

private void validateLicense(ExtensionProcessor processor, ExtensionVersion extVersion) {
Expand Down
13 changes: 0 additions & 13 deletions server/src/test/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,19 +275,6 @@ void shouldFailWhenPackageJsonDoesNotMatchManifest() throws IOException {
assertThatThrownBy(() -> handler.createExtensionVersion(processor, token, LocalDateTime.now(), false))
.isInstanceOf(ErrorResultException.class)
.hasMessageContaining("Extension version in extension.vsixmanifest");

when(processor.getPackageMetadata()).thenReturn(
new ExtensionProcessor.PackageMetadata(
"publisher",
"demo",
"2.0.0",
"Demo Not OK"
)
);

assertThatThrownBy(() -> handler.createExtensionVersion(processor, token, LocalDateTime.now(), false))
.isInstanceOf(ErrorResultException.class)
.hasMessageContaining("Display name in extension.vsixmanifest");
}
}

Expand Down
Loading