fix: align the Kubernetes ConfigMap with the Spring Boot 4 properties - #2158
Merged
Conversation
The Kubernetes manifests were added after the other deployment descriptors, and the two commits that realigned those afterwards left them behind: 46459f4 (Spring Boot 4 base configuration) and fbdd4bd (springdoc alignment) both skipped deploy/kubernetes. Three of the keys therefore no longer bind to anything: - JobRunr dropped the org. prefix in version 7, so the whole block under org.jobrunr was ignored and both the job scheduler and the background job server silently ran with their defaults. - ZipkinAutoConfiguration moved to org.springframework.boot.zipkin .autoconfigure in Spring Boot 4, so the exclude no longer matched a class. - spring.thymeleaf.enabled is gone; check-template-location is what suppresses the missing template location now. Also add the springdoc keys the other deployments already carry, so the swagger-ui served from the Kubernetes example behaves the same. Fixes #2157 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The updated Kubernetes ConfigMap properties match the repo’s existing Spring Boot 4 configuration patterns (docker/openshift/dev) and resolve the reported non-binding keys without introducing new risk.
Pull request overview
This PR updates the Kubernetes deployment example’s ConfigMap application configuration to match the Spring Boot 4 / springdoc / JobRunr property keys already used by the other deployment descriptors and server/src/dev, fixing config keys that no longer bind.
Changes:
- Update
spring.autoconfigure.excludeto the Spring Boot 4ZipkinAutoConfigurationclass location. - Replace deprecated
spring.thymeleaf.enabledwithspring.thymeleaf.check-template-location. - Align
jobrunr.*and add the missingspringdoc.*keys so the Kubernetes example matches other deployment configs.
File summaries
| File | Description |
|---|---|
| deploy/kubernetes/configmap.yaml | Align embedded application.yml keys with Spring Boot 4 / springdoc / JobRunr property names used elsewhere in the repo |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2157
deploy/kubernetes/was added in #1792, after the other deployment descriptors, and the two commits that realigned those afterwards left it behind: 46459f4 (Spring Boot 4 base configuration) and fbdd4bd (springdoc alignment) both updateddeploy/docker,deploy/openshiftandserver/src/devbut skippeddeploy/kubernetes.Three keys in the ConfigMap therefore no longer bind to anything:
org.jobrunr.*jobrunr.*spring.autoconfigure.excludeorg.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinAutoConfigurationorg.springframework.boot.zipkin.autoconfigure.ZipkinAutoConfigurationspring.thymeleafenabled: falsecheck-template-location: falseorg.prefix in version 7 —jobrunr-spring-boot-4-starter:8.6.1declares the group namejobrunrin itsspring-configuration-metadata.json. Nothing bound, so both the job scheduler and the background job server silently ran with their defaults, which is what @nh60211as observed in Kubernetes Deployment Example Seems Outdated #2157.ZipkinAutoConfigurationmoved packages in Spring Boot 4;spring-boot-zipkin:4.0.8only carriesorg/springframework/boot/zipkin/autoconfigure/ZipkinAutoConfiguration.class, so the exclude matched no class.spring.thymeleaf.enabledis gone;check-template-locationis what suppresses the missing template location now.The
springdockeys the other two deployments already carry are added as well, so the swagger-ui served from the Kubernetes example behaves the same.After the change the embedded
application.ymldiffers fromdeploy/openshift/application.ymlonly in the intentional Kubernetes-specific bits: secret-backed DB credentials, commented-out GitHub OAuth,management.health.redis.enabled: false(no Redis in this example and bucket4j is off), and noovsx.registry.versionplaceholder since the image tag carries it.🤖 Generated with Claude Code