feat(os): add Linux syslog OS wrapper for score::os::Syslog by btirunagaru · Pull Request #502 · eclipse-score/baselibs

btirunagaru · 2026-08-21T19:47:26Z

Description

Adds score::os::Syslog, a new OS-abstraction wrapper (interface +
impl + mock) around glibc's openlog(3)/syslog(3)/closelog(3),
following the existing score::os::qnx::Slog2 pattern. Includes unit
tests under score/os/test/linux/, reusing the existing generic
OS-wrapper requirement SCR-46010294.

This is a prerequisite for a companion contribution to the logging
component (eclipse-score/logging#270), which consumes
@score_baselibs//score/os:syslog to implement the LogMode::kSystem
backend for mw::log on Linux.

Related ticket

closes #501

4og · 2026-08-24T07:27:04Z

+  public:
+    static score::cpp::pmr::unique_ptr<Syslog> Default(score::cpp::pmr::memory_resource* memory_resource) noexcept;
+
+    /* KW_SUPPRESS_START:MISRA.VAR.HIDDEN:Wrapper function is identifiable through namespace usage */


Please do not add KW_ markers. These are legacy and should actually be removed from the entire codebase.

Done. Fixed in the new review.

4og · 2026-08-24T07:28:02Z

+    Syslog() = default;
+
+    virtual ~Syslog() = default;
+    // Below special member functions declared to avoid autosar_cpp14_a12_0_1_violation


Please do not add this comment. This repo aims to adhere to MISRA guidelines and not AUTOSAR

Done. Fixed in the new review.

4og · 2026-08-24T07:52:46Z

@@ -0,0 +1,52 @@
+/********************************************************************************
+ * Copyright (c) 2025 Contributors to the Eclipse Foundation


Please set year to 2026 everywhere

Done. Fixed in the new review.

4og · 2026-08-24T07:55:46Z

+
+/// @brief Object-seam wrapper around the POSIX/glibc syslog(3) family.
+///
+/// Mirrors the QNX @ref score::os::qnx::Slog2 wrapper so that the platform-native


This comment looks redundant. The slog2 API is completely different.

Done. Fixed in the new review.

4og · 2026-08-24T07:59:09Z

+    ],
+    features = COMPILER_WARNING_FEATURES,
+    tags = ["FFI"],
+    target_compatible_with = ["@platforms//os:linux"],


QNX has syslog API as well

But the idea to use slog on qnx and only syslog on linux providing the equivalent functionality on target.

Why not to give freedom to use it also on QNX? I would add qnx target as far as code is the same

as i mentioned - the kSystem log mode on QNX is already filled by slog and its widely used on QNX and it make sense to use that.
so i would assume the choice of the users to use slog vs syslog on QNX is more of a different ask. Till the community show interest to have this dual choice. its best we treat this and compile for Linux only and enable for QNX later (until we find a genuine user for this back end)
If there is a interest and the enablement for QNX can come later as a different requirement if that's the need.

github-actions · 2026-09-03T07:56:00Z

Documentation preview for this pull request is available at:
pr-502: https://eclipse-score.github.io/baselibs/pr-502/

btirunagaru · 2026-09-08T20:59:58Z

Hi @btirunagaru, Can you please update the branch and address the remaining CI issues?

Yes, i raised another commit with fixes for those CI workflows - please review.

rmaddikery · 2026-09-09T16:10:16Z

+    ::openlog(ident, option, facility);
+}
+
+// coverity[autosar_cpp14_a8_4_1_violation]: see above


I do not see any argumentation for the suppression.

@4og

Please do not add KW_ markers. These are legacy and should actually be removed from the entire codebase.

This was the comment provided to me earlier so had to remove those annotation or argumentation - see my first review those should be there - let me know if you want me to bring it in.

rmaddikery · 2026-09-09T16:11:21Z

+                 const std::int32_t option,
+                 const std::int32_t facility) const noexcept override;
+
+    // coverity[autosar_cpp14_a8_4_1_violation]: see above


@rmaddikery done cleaned up -squashed both PRs.

Add a Linux implementation of the Syslog object seam that forwards openlog(), syslog(), and closelog() calls to the POSIX API. - Add the Syslog interface, Linux implementation, and default factory. - Add a mock implementation and Linux unit tests. - Include the production implementation in the coverage scope. - Preserve the POSIX-compatible C-style variadic interface. - Retain only the required clang-tidy suppressions for the variadic adapters. - Remove the stale Coverity 'see above' comments from the Linux syslog declaration and definition. Verification: - Linux syslog unit test passed. - C++ formatting check passed. - Targeted clang-tidy build passed. - Coverage scope check passed. - git diff --check passed.

+#include <cstdio>
+#include <string>
+
+namespace score


+void MockSyslog::syslog(std::int32_t priority, const char* format, ...) const noexcept
+{
+    // Create a va_list to hold the variable arguments
+    va_list args;


+{
+    // Create a va_list to hold the variable arguments
+    va_list args;
+    va_start(args, format);


+    va_start(args, format);
+
+    // Determine required buffer size
+    const auto message_length = std::vsnprintf(nullptr, 0, format, args);


+    const auto message_length = std::vsnprintf(nullptr, 0, format, args);
+
+    // Reset the va_list to be able to use it again
+    va_end(args);


+
+    // Googletest does not support variadic arguments. Therefore we pass through the formatted string so that we can
+    // use it with MOCK_METHOD.
+    MOCK_METHOD(void, MockedSyslog, (std::int32_t priority, const std::string& message), (const, noexcept));


+
+#include "score/os/syslog_impl.h"
+
+namespace score


+
+#include <syslog.h>
+
+namespace score


+
+#include <cstdarg>
+
+namespace score


+
+#include "score/os/syslog.h"
+
+namespace score


github-project-automation Bot added this to BAS - Baselibs FT Aug 21, 2026

github-project-automation Bot moved this to In Progress in BAS - Baselibs FT Aug 21, 2026

btirunagaru deployed to workflow-approval August 21, 2026 19:47 — with GitHub Actions Active

github-actions Bot added comp-osal Related to score/os component c++ C++ code bazel Bazel and Starlark build files labels Aug 21, 2026

btirunagaru mentioned this pull request Aug 21, 2026

feat(mw/log): add Linux syslog backend for LogMode::kSystem eclipse-score/logging#271

Open

4og requested changes Aug 24, 2026

View reviewed changes

btirunagaru deployed to workflow-approval August 24, 2026 18:03 — with GitHub Actions Active

btirunagaru deployed to workflow-approval August 26, 2026 18:31 — with GitHub Actions Active

btirunagaru marked this pull request as ready for review August 26, 2026 18:32

btirunagaru requested review from antonkri, arkjedrz, fbaeuerle and pawelrutkaq as code owners August 26, 2026 18:32

btirunagaru requested a review from 4og August 27, 2026 18:34

btirunagaru deployed to workflow-approval September 2, 2026 18:45 — with GitHub Actions Active

btirunagaru requested a deployment to workflow-approval September 8, 2026 20:52 — with GitHub Actions Waiting

btirunagaru force-pushed the feat/syslog_on_linux branch from a0a3faa to 408be67 Compare September 8, 2026 20:52

btirunagaru requested a deployment to workflow-approval September 8, 2026 20:52 — with GitHub Actions Waiting

rmaddikery reviewed Sep 9, 2026

View reviewed changes

btirunagaru force-pushed the feat/syslog_on_linux branch from 408be67 to 37847ba Compare September 10, 2026 16:26

btirunagaru requested a deployment to workflow-approval September 10, 2026 16:26 — with GitHub Actions Waiting

github-actions Bot added the comp-flatbuffers Related to score/flatbuffers component label Sep 10, 2026

btirunagaru force-pushed the feat/syslog_on_linux branch from 37847ba to 500cc96 Compare September 10, 2026 16:45

btirunagaru requested a deployment to workflow-approval September 10, 2026 16:46 — with GitHub Actions Waiting

github-actions Bot removed the comp-flatbuffers Related to score/flatbuffers component label Sep 10, 2026

btirunagaru force-pushed the feat/syslog_on_linux branch from 500cc96 to 253fd2e Compare September 11, 2026 18:07

btirunagaru deployed to workflow-approval September 11, 2026 18:07 — with GitHub Actions Active

github-advanced-security Bot found potential problems Sep 14, 2026

View reviewed changes

		@@ -0,0 +1,52 @@
		/********************************************************************************
		* Copyright (c) 2025 Contributors to the Eclipse Foundation

Conversation

btirunagaru commented Aug 21, 2026

Description

Related ticket

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

btirunagaru Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

btirunagaru commented Sep 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

btirunagaru Aug 26, 2026 •

edited

Loading