feat(bazel): updated score_bazel_cpp_toolchains to 1.0.2; add score_cpp_policies 0.1.0 as dev_dependency; add injectable warning features for gcc warnings in all gcc toolchains and the llvm toolchain - #524
Open
ian-harmon-traton wants to merge 6 commits into
Open
ian-harmon-traton wants to merge 6 commits into
ian-harmon-traton wants to merge 6 commits into
Conversation
…cies 0.1.0 as dev_dependency; add injectable warning features for gcc warnings in all gcc toolchains and the llvm toolchain
ian-harmon-traton
requested review from
4og,
antonkri,
arkjedrz,
fbaeuerle and
pawelrutkaq
as code owners
August 26, 2026 15:38
ian-harmon-traton
requested a deployment
to
workflow-approval
August 26, 2026 15:39 — with 
GitHub Actions
Queued
GitHub Actions
Queued
ian-harmon-traton
requested a deployment
to
workflow-approval
August 26, 2026 15:39 — with
GitHub Actions
Queued
GitHub Actions
Queued
ian-harmon-traton
requested a deployment
to
workflow-approval
August 26, 2026 15:39 — with
GitHub Actions
Queued
GitHub Actions
Queued
ian-harmon-traton
requested a deployment
to
workflow-approval
August 26, 2026 15:39 — with
GitHub Actions
Queued
GitHub Actions
Queued
ian-harmon-traton
changed the title
3 tasks
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
Suppressed comments (4)
MODULE.bazel:55
- The new multiline argument is missing the trailing comma used throughout this file, so the checked Starlark formatter will report a difference.
extra_known_features = SCORE_GCC_WARNING_FEATURES_POLICY
MODULE.bazel:46
- This added argument is not in the repository's formatted Starlark form, and the following whitespace-only line is also introduced here. Remove that line and add the trailing comma so
format.checkpasses.
extra_known_features = SCORE_GCC_WARNING_FEATURES_POLICY
MODULE.bazel:64
- The new multiline argument is missing the trailing comma used throughout this file, so the checked Starlark formatter will report a difference.
extra_known_features = SCORE_GCC_WARNING_FEATURES_POLICY
MODULE.bazel:153
- The new multiline argument is missing the trailing comma used throughout this file, so the checked Starlark formatter will report a difference.
extra_known_features = SCORE_GCC_WARNING_FEATURES_POLICY
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ian Harmon (Traton R&D US) <ian.harmon@us.traton.com>
4og
reviewed
Aug 28, 2026
4og
left a comment
4og
left a comment
Member
There was a problem hiding this comment.
Hi @ian-harmon-traton, thank you for the contribution! I'll check this PR on Monday.
Contributor
|
Documentation preview for this pull request is available at: |
4og
requested changes
Aug 31, 2026
4og
left a comment
4og
left a comment
Member
There was a problem hiding this comment.
See my comments.
To fix the formatting issues, simply run bazel run //:format.fix
| target_os = "linux", | ||
| use_default_package = True, | ||
| version = "12.2.0", | ||
| extra_known_features = SCORE_GCC_WARNING_FEATURES_POLICY, |
Member
There was a problem hiding this comment.
An extra_enabled_features needs to be added additionally. And it should list minimal_warnings and warnings_as_errors.
And then this line can be removed:
Line 41 in bed5b98
Author
|
Been busy this week - I'll push the suggested changes ASAP, thank you for the review and comments! |
…tures from llvm toolchains; add all relevant changes to example integration MODULE.bazel
ian-harmon-traton
requested a deployment
to
workflow-approval
September 3, 2026 15:30 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ian-harmon-traton
requested a deployment
to
workflow-approval
September 3, 2026 15:30 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ian-harmon-traton
requested a deployment
to
workflow-approval
September 3, 2026 15:30 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ian-harmon-traton
requested a deployment
to
workflow-approval
September 3, 2026 15:30 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ian-harmon-traton
deployed
to
workflow-approval
September 3, 2026 15:35 — with
GitHub Actions
Active
GitHub Actions
Active
ian-harmon-traton
deployed
to
workflow-approval
September 3, 2026 15:35 — with
GitHub Actions
Active
GitHub Actions
Active
ian-harmon-traton
deployed
to
workflow-approval
September 3, 2026 15:35 — with
GitHub Actions
Active
GitHub Actions
Active
ian-harmon-traton
deployed
to
workflow-approval
September 3, 2026 15:35 — with
GitHub Actions
Active
GitHub Actions
Active
Author
|
Added suggested changes and merged with latest Main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the need for migrating to injectable warning features as mentioned in #519
What Changed
Validation
Build passes.
All unit tests passed except:
//score/language/safecpp/aborts_upon_exception:abortsuponexception_toolchain_test FAILED