static_reflection_with_serialization: migrate test requirement links - #573
Draft
Nikhil2206 wants to merge 2 commits into
Draft
Nikhil2206 wants to merge 2 commits into
Nikhil2206 wants to merge 2 commits into
Conversation
Replace legacy RecordProperty metadata (ParentRequirement/SCR-* IDs, ASIL, TestingTechnique) with FullyVerifies/PartiallyVerifies links to comp_req__static_reflect_serial__* IDs, TestType, and DerivationTechnique across all 41 tests in the component's 8 test files.
Nikhil2206
requested review from
4og,
antonkri,
arkjedrz,
fbaeuerle and
pawelrutkaq
as code owners
September 10, 2026 09:48
Contributor
|
Documentation preview for this pull request is available at: |
Nikhil2206
marked this pull request as draft
September 11, 2026 08:24
Nikhil2206
requested a deployment
to
workflow-approval
September 11, 2026 08:24 — with
GitHub Actions
Waiting
Nikhil2206
requested a deployment
to
workflow-approval
September 11, 2026 08:24 — with
GitHub Actions
Waiting
Nikhil2206
requested a deployment
to
workflow-approval
September 11, 2026 08:24 — with
GitHub Actions
Waiting
Nikhil2206
requested a deployment
to
workflow-approval
September 11, 2026 08:24 — with
GitHub Actions
Waiting
Nikhil2206
requested a deployment
to
workflow-approval
September 17, 2026 05:48 — with
GitHub Actions
Waiting
Nikhil2206
requested a deployment
to
workflow-approval
September 17, 2026 05:48 — with
GitHub Actions
Waiting
Nikhil2206
requested a deployment
to
workflow-approval
September 17, 2026 05:48 — with
GitHub Actions
Waiting
Nikhil2206
requested a deployment
to
workflow-approval
September 17, 2026 05:48 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the #522 test-to-requirement traceability cleanup, following
.agents/skills/requirements-management-skill/test-to-requirement-linking.md.score/static_reflection_with_serializationalready had a full requirements doc (docs/requirements/index.rst, 6comp_reqentries) but all 41 tests used legacyRecordPropertymetadata (ParentRequirementwithSCR-*IDs,ASIL,TestingTechnique). This PR migrates every test to the current convention:FullyVerifies/PartiallyVerifiespointing atcomp_req__static_reflect_serial__*,TestType, andDerivationTechnique, with a non-mechanicalDescriptionfor each. No test bodies or assertions were changed.Files touched
serialization/test/ut/test_serializer_visitor.cpp(23 tests)serialization/test/ut/test_size_visitor.cpp(1TYPED_TEST_P)serialization/test/ut/test_skip_deserialize.cpp(2 tests)serialization/test/ut/test_visitor_type_traits.cpp(2 tests)visitor/test/ut/test_detail.cpp(2 tests)visitor/test/ut/test_struct_visitor.cpp(5 tests, one of which —TupleToArrayTest— had noRecordPropertyat all and was linked from scratch)visitor/test/ut/test_visitor.cpp(4 tests)visitor/examples/ostream/test/ut/test_ostream_visitor.cpp(2 tests, already hadTestType, added the missingPartiallyVerifies/DerivationTechnique)Validation
bazel test --config=bl-x86_64-linux //score/static_reflection_with_serialization/...— 5/5 targets pass.bazel run //:docsis currently blocked in my sandbox by a pre-existing root-owned_build/permission error, unrelated to this change (PermissionErroron_build/warnings.txt). As a fallback I manually cross-checked everycomp_req__static_reflect_serial__*ID used againstdocs/requirements/index.rstin this component — all resolve to an existing,status: validrequirement.bazel run //:format.fix -- <touched files>— clean, no reformatting beyond the intended edits.Deliberately left unlinked
Nothing in this component was left unlinked — all 41 tests across all 8 test files now carry current metadata.
Flagged requirement-quality issues
test_serializer_visitor.cppexercise more than onecomp_reqin a single test body (e.g.serializer_visitor.serializerround-trips containers, nested structs, and core scalar serialization all in one ~200-line test). I used comma-separatedPartiallyVerifieslists where a test genuinely exercises multiple requirements, per the skill's guidance, rather than splitting the tests (out of scope for a metadata-only pass).comp_req__static_reflect_serial__header_onlyandcomp_req__static_reflect_serial__compile_eff(non-functional requirements about header-only packaging and compile-time efficiency) have no corresponding runtime test in this suite — there is no unit test that could exercise these; flagging in case the requirements owner wants a build-structure check or a static/compile-time assertion added.