Conversation
Deeply-nested Bazel target paths flattened into a filename can exceed the filesystem's 255-byte limit and crash clean_lint_sarif.py. The merge step only globs for "*.sarif", so a hash is enough to keep names unique. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fbaeuerle
requested review from
4og,
antonkri,
arkjedrz and
pawelrutkaq
as code owners
September 17, 2026 11:49
Contributor
|
Documentation preview for this pull request is available at: |
fbaeuerle
force-pushed
the
fb/541/manual_targets
branch
from
September 17, 2026 12:47
287b91c to
92125d3
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The non-blocking manual-target step can silently skip lint coverage when discovery or lint execution fails.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds lint coverage for compatible Bazel targets tagged manual.
Changes:
- Discovers compatible manual C++, Rust, and Python targets.
- Runs linters separately for those targets.
- Hashes SARIF filenames to avoid filesystem limits.
File summaries
| File | Description |
|---|---|
.github/workflows/lint.yml |
Adds manual-target linting. |
.github/tools/manual_lint_targets.sh |
Finds compatible lintable manual targets. |
.github/tools/clean_lint_sarif.py |
Uses hashed SARIF filenames. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bazel excludes manual targets from //..., so rules_lint aspects never see them. Build them explicitly by name in a separate, non-blocking step so clang-tidy/Clippy/Ruff still catch issues in them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fbaeuerle
force-pushed
the
fb/541/manual_targets
branch
from
September 17, 2026 15:19
92125d3 to
46cf5d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also targets that are tagged
manualare worthy of linting. Ensure they are linted without breaking the build.Closes: #541