Add patches support for SDP toolchain archives - #111
Merged
Merged
Conversation
nradakovic
requested review from
AlexanderLanin,
antonkri and
dcalavrezo-qorix
as code owners
July 23, 2026 12:24
nradakovic
added
documentation
nradakovic
force-pushed
the
nira_add_patch_sdp
branch
3 times, most recently
from
July 24, 2026 09:17
fd13a59 to
fa2bcfc
Compare
nradakovic
force-pushed
the
nira_add_patch_sdp
branch
from
August 7, 2026 08:24
3af13b5 to
a806424
Compare
nradakovic
marked this pull request as draft
August 13, 2026 13:32
nradakovic
force-pushed
the
nira_add_patch_sdp
branch
4 times, most recently
from
September 16, 2026 08:07
72620b9 to
5cd3c96
Compare
nradakovic
marked this pull request as ready for review
September 16, 2026 12:39
nradakovic
force-pushed
the
nira_add_patch_sdp
branch
from
September 16, 2026 12:42
5cd3c96 to
e2b148d
Compare
antonkri
previously approved these changes
Sep 16, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical and moderate package-metadata issues remain, along with documentation nits.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (2)
docs/extension_api.md:53
- The new description says all tag attributes pass through 1:1, but the implementation normalizes
urltourls = [url]and exposes only a curated subset ofhttp_archiveattributes. This is misleading for consumers who expect other native attributes to work; describegcc.sdpas a supported-subset proxy instead.
required. The tag is nothing more than a thin proxy to the native `http_archive`
repository rule: its attributes are passed straight through to `http_archive`
with no additional processing.
packages/version_matrix.bzl:23
- The new
patchesfield is only present on six matrix entries; entries such asaarch64-linux-gcc_15.3.0,aarch64-qnx-sdp_8.0.4,x86_64-qnx-sdp_8.0.0, andx86_64-qnx-sdp_8.0.5still omit it. This leavesVERSION_MATRIXwith an inconsistent schema instead of the promised empty-list default for every entry, so add"patches": []to every non-patched entry as well.
"patches": [],
- Files reviewed: 7/8 changed files
- Comments generated: 3
- Review effort level: Lite
nradakovic
force-pushed
the
nira_add_patch_sdp
branch
2 times, most recently
from
September 16, 2026 13:04
fef655c to
db7ad6c
Compare
nradakovic
force-pushed
the
nira_add_patch_sdp
branch
from
September 16, 2026 13:07
db7ad6c to
f10cb73
Compare
Introduce a patches to the SDP tag class so patches can be applied to downloaded toolchain archives. The attributes are threaded through `_get_packages`, `_create_and_link_sdp`, and the archive download in `_impl`. Documentation is also update to follow up new attribute set.
nradakovic
force-pushed
the
nira_add_patch_sdp
branch
from
September 16, 2026 13:22
f10cb73 to
ccbdcac
Compare
antonkri
approved these changes
Sep 16, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
patchesattribute to the SDP tag class so patches can be applied to downloaded toolchain archives. The attribute is threaded through_get_packages,_create_and_link_sdp, and the archive download in_impl.Add a
patcheskey to every entry in VERSION_MATRIX (defaulting to an empty list) and wire up the QNX SDP 8.0.4 packages to the packages/qnx/aarch64/sdp/8.0.0:patches target.