Nira feature reorder - #123
Merged
Merged
Conversation
Reorder feature list
nradakovic
requested review from
AlexanderLanin,
antonkri and
dcalavrezo-qorix
as code owners
August 20, 2026 15:50
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a QNX-specific coverage smoke test and updates toolchain feature ordering to support bazel coverage runs in QNX CI.
Changes:
- Introduces
qnx_coverage_testand wires it into Bazel targets/suites. - Updates QNX + Linux toolchain feature ordering; adds a QNX
gcov_runtimelink feature. - Extends the QNX GitHub Actions workflow to run a
bazel coveragesmoke step.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/feature_verification/qnx_coverage_test.cpp | New QNX-focused coverage smoke test binary (cc_test) |
| tests/feature_verification/BUILD | Adds qnx_coverage_test cc_test target |
| tests/BUILD | Adds qnx_coverage_test to the feature verification test suite |
| templates/qnx/cc_toolchain_config.bzl.template | Reorders warning features; adds always-enabled gcov_runtime link feature and reorders it |
| templates/linux/cc_toolchain_config.bzl.template | Reorders warning features in the features list |
| .github/workflows/qnx.yml | Adds a bazel coverage smoke-test step for QNX toolchain |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+102
to
+105
| bazel coverage --config ${{ matrix.bazel-config }} \ | ||
| --combined_report=lcov \ | ||
| --credential_helper=*.qnx.com="${QNX_CREDENTIAL_HELPER}" -- \ | ||
| //feature_verification:qnx_coverage_test |
Comment on lines
+796
to
+800
| # Linked unconditionally (not gated behind the coverage feature) so that code | ||
| # calling gcov runtime functions directly (e.g. __gcov_dump) resolves even | ||
| # outside bazel coverage runs. Must come after libraries_to_link_feature in | ||
| # the features list: libgcov is a static archive, and the linker only pulls | ||
| # in archive members for symbols that are already undefined at that point |
Comment on lines
+14
to
+18
| // Coverage smoke test dedicated to QNX CI runners. | ||
| // | ||
| // Unlike feature_verification:coverage_test (which only needs to build and run | ||
| // on any host), this target is meant to be executed with `bazel coverage` on | ||
| // real QNX hardware/CI, to confirm the full build -> link -> execute -> gcov |
Comment on lines
47
to
51
| "//feature_verification:pic_test", | ||
| "//feature_verification:preprocessor_defines_test", | ||
| "//feature_verification:pthread_test", | ||
| "//feature_verification:qnx_coverage_test", | ||
| "//feature_verification:random_seed_test", |
Add fix for QNX coverage
nradakovic
force-pushed
the
nira_feature_reorder
branch
from
August 20, 2026 16:12
ea0a498 to
0bc2b8a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Suppressed comments (1)
.github/workflows/qnx.yml:105
- The aarch64 matrix entry explicitly raises test timeouts because execution under QEMU is slow, but this new
bazel coverageinvocation does not forwardmatrix.extra-bazel-test-flags. Coverage executes the same emulated test with added instrumentation/gcov work, so the aarch64 job falls back to Bazel's default timeout and can fail even though the regular test step receives the required override. Pass the matrix flags to this command as well.
bazel coverage --config ${{ matrix.bazel-config }} \
--combined_report=lcov \
--credential_helper=*.qnx.com="${QNX_CREDENTIAL_HELPER}" -- \
//feature_verification:coverage_test
Comment on lines
+1027
to
+1030
| minimal_warnings_feature, | ||
| strict_warnings_feature, | ||
| all_wall_warnings_feature, | ||
| warnings_as_errors_feature, |
Comment on lines
+811
to
+814
| minimal_warnings_feature, | ||
| strict_warnings_feature, | ||
| all_wall_warnings_feature, | ||
| warnings_as_errors_feature, |
AlexanderLanin
approved these changes
Aug 24, 2026
AlexanderLanin
left a comment
AlexanderLanin
left a comment
Member
There was a problem hiding this comment.
Please judge AI feedback yourself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.