Fix the sysroot dir for Aarch64 build on AutoSD - #144
Merged
Merged
Conversation
Fix the sysroot directory to point to whole directory instead of list of files. resolves #142
nradakovic
requested review from
AlexanderLanin,
antonkri and
dcalavrezo-qorix
as code owners
September 15, 2026 12:43
nradakovic
added
bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused sysroot correction has no unresolved review issues.
Pull request overview
Fixes the AutoSD AArch64 compiler sysroot to reference the complete extracted package directory.
Changes:
- Replaces the file glob with the package-root directory target.
- Aligns the configuration with existing toolchain packages.
File summaries
| File | Description |
|---|---|
packages/linux/aarch64/autosd/10.0/autosd.BUILD |
Corrects the sysroot_dir target. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
odra
approved these changes
Sep 15, 2026
AlexanderLanin
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the sysroot directory to point to whole directory instead of list of files.
resolves #142