Skip to content

fix(service): add proxy_data stub and fix ProvidedServices count trac… - #749

Merged
LittleHuba merged 2 commits into
eclipse-score:mainfrom
Chahult:fix/v0.2.1_provided_service_container_count
Jul 28, 2026
Merged

LittleHuba merged 2 commits into
eclipse-score:mainfrom
Chahult:fix/v0.2.1_provided_service_container_count

Conversation

@Chahult

@Chahult Chahult commented Jul 23, 2026

Copy link
Copy Markdown

Based on v0.2.1 tag:

  • Add proxy_data.h: OptionalProxyData alias for Optional
  • Add proxy_data cc_library to score/mw/service/BUILD
  • Fix ProvidedServices Add() to increment count_ so Count() returns the actual number of added services (was always returning 0)
  • Fix Swap() to exchange count_ values
  • Add private count_ member

@castler castler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please elaborate what we are trying to achieve with this changset?

The current mw::service implementation is just a bare frontend that is there for working compilation. We are right now working of the open sourcing of the current implementation.

If this was rather just some try-out PR, maybe we can mark it as "draft"?

@Chahult

Chahult commented Jul 24, 2026

Copy link
Copy Markdown
Author

Can you please elaborate what we are trying to achieve with this changset?

The current mw::service implementation is just a bare frontend that is there for working compilation. We are right now working of the open sourcing of the current implementation.

If this was rather just some try-out PR, maybe we can mark it as "draft"?

config_management's unit tests use mw::service types from the communication library. Two concrete problems were hit:

1.ProvidedServices::Count() always returned 0 — Add() was never incrementing the internal count_ member, so any test checking how many services were registered would always see 0 regardless of how many were added. Swap() also didn't exchange count_ values.

2.proxy_data.h / OptionalProxyData didn't exist — config_management's code uses OptionalProxyData (an alias for Optional), but the file was missing from score/mw/service/.

Both are in the current bare-frontend placeholder implementation of mw::service. The PR adds the missing header and fixes the broken counter so config_management's unit tests can compile and pass correctly

@Chahult

Chahult commented Jul 24, 2026

Copy link
Copy Markdown
Author

Can you please elaborate what we are trying to achieve with this changset?

The current mw::service implementation is just a bare frontend that is there for working compilation. We are right now working of the open sourcing of the current implementation.

If this was rather just some try-out PR, maybe we can mark it as "draft"?

This PR is a prerequisite for our unit test traceability work in config_management (eclipse-score/config_management#30)
Would appreciate a review so we can proceed. Happy to adjust if there's a preferred approach.

@Chahult
Chahult requested a review from castler July 24, 2026 08:31
@Chahult
Chahult force-pushed the fix/v0.2.1_provided_service_container_count branch 2 times, most recently from a14faa1 to 1487f79 Compare July 27, 2026 06:11
@Chahult

Chahult commented Jul 27, 2026

Copy link
Copy Markdown
Author

@castler @LittleHuba Please review

@Chahult
Chahult force-pushed the fix/v0.2.1_provided_service_container_count branch from 1487f79 to e333ca0 Compare July 28, 2026 07:30
@LittleHuba

Copy link
Copy Markdown
Contributor

Unlocked the workflows for you. You are at least missing the update of our visibility checker.
Once all your workflows are green, we'll do a review.

…king

Based on v0.2.1 tag:
- Add proxy_data.h: OptionalProxyData<T> alias for Optional<T>
- Add proxy_data cc_library to score/mw/service/BUILD
- Fix ProvidedServices Add() to increment count_ so Count() returns
  the actual number of added services (was always returning 0)
- Fix Swap() to exchange count_ values
- Add private count_ member
@Chahult
Chahult force-pushed the fix/v0.2.1_provided_service_container_count branch from e333ca0 to 4658ffb Compare July 28, 2026 08:54
@Chahult

Chahult commented Jul 28, 2026

Copy link
Copy Markdown
Author

Unlocked the workflows for you. You are at least missing the update of our visibility checker. Once all your workflows are green, we'll do a review.

Unlocked the workflows for you. You are at least missing the update of our visibility checker. Once all your workflows are green, we'll do a review.

Could you please Unlock the workflow again

@LittleHuba
LittleHuba added this pull request to the merge queue Jul 28, 2026
Merged via the queue into eclipse-score:main with commit 8999815 Jul 28, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in COM - Communication FT Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants