fix(service): add proxy_data stub and fix ProvidedServices count trac… - #749
Conversation
7564ff5 to
57eb852
Compare
castler
left a comment
There was a problem hiding this comment.
Can you please elaborate what we are trying to achieve with this changset?
The current mw::service implementation is just a bare frontend that is there for working compilation. We are right now working of the open sourcing of the current implementation.
If this was rather just some try-out PR, maybe we can mark it as "draft"?
config_management's unit tests use mw::service types from the communication library. Two concrete problems were hit: 1.ProvidedServices::Count() always returned 0 — Add() was never incrementing the internal count_ member, so any test checking how many services were registered would always see 0 regardless of how many were added. Swap() also didn't exchange count_ values. 2.proxy_data.h / OptionalProxyData didn't exist — config_management's code uses OptionalProxyData (an alias for Optional), but the file was missing from score/mw/service/. Both are in the current bare-frontend placeholder implementation of mw::service. The PR adds the missing header and fixes the broken counter so config_management's unit tests can compile and pass correctly |
This PR is a prerequisite for our unit test traceability work in config_management (eclipse-score/config_management#30) |
a14faa1 to
1487f79
Compare
|
@castler @LittleHuba Please review |
1487f79 to
e333ca0
Compare
|
Unlocked the workflows for you. You are at least missing the update of our visibility checker. |
…king Based on v0.2.1 tag: - Add proxy_data.h: OptionalProxyData<T> alias for Optional<T> - Add proxy_data cc_library to score/mw/service/BUILD - Fix ProvidedServices Add() to increment count_ so Count() returns the actual number of added services (was always returning 0) - Fix Swap() to exchange count_ values - Add private count_ member
e333ca0 to
4658ffb
Compare
Could you please Unlock the workflow again |
Based on v0.2.1 tag: