Conversation
c5a23e9 to
2050a3c
Compare
|
@antonkri There is no description or anything what this PR should acomplish, why it is needed or what it builds towards / upon. It's a bit hard to review it without that knowledge. Could you add this to the PR description please? Thanks. |
|
And how it achieves what it does, as its very difficult to infer that from reading the code. |
f88cd6d to
9c5100c
Compare
|
@antonkri thanks that helps a lot! review in progress (not a request to change anything yet!)
|
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
First of all, thanks for the contribution, it seems like something that actually is a good idea (to add coverage to the documentation and implement it directly), so thanks a ton for that.
I have not gone through the code itself in detail as I think there is some fundamental thing to fix here first.
The first question to answer is if we want the coupling between component / feature / module source_code and the requirements. @AlexanderLanin also curious about your opinion here.
If we do want this then the following issues arise.
We first need a way to find a better way to correlate which sources belong to which component / feature / module etc.
The way you propose here in the PR via folders mentioned in the mod, at least to me, seems error prone and also is not a strong automatic coupling between the two.
I have not yet fully thought through the problem, so I don't have a better solution currently.
But I also fear if we don't think this through, that this shaky temporary setup will be used for a long time and we have trouble changing it in the future.
I would like to think through this, and discuss this internally with the other DaC maintainers to see what they may think about this and if there is good ideas.
And once we have those (how to couple the things) then I'm sure that you can take a lot of your implementation and adapt it to that new way of linking it and do it right from the start.
Or at least closer to a more permanent solution.
PR incoming 🤣 |
📌 Description
This PR extends Module Verification Report with the functionality to collect code coverage data (after bazel coverage command), aggregate those data per component (:comp) and render this data in the final documentation using module verification report post-template. As the mapping between (sub-)components at the architectural level and source code folders is not clear, and this is needed to know which files belong to which component, module definition (:mod) was extended to provide this additional information. For more information see README.
🚨 Impact Analysis
✅ Checklist