refactor: use execpath in genrule commands - #835
Merged
AlexanderLanin merged 1 commit intoSep 16, 2026
Merged
AlexanderLanin merged 1 commit into
AlexanderLanin merged 1 commit into
Conversation
AlexanderLanin
requested review from
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
September 16, 2026 14:18
Contributor
|
Documentation preview for this pull request is available at: |
| # Run the generator on the YAML input and tell it where to write the RST | ||
| # and Mermaid files. Bazel expands each $(execpath ...) to the named tool | ||
| # or file's path in this build action, so the command can find them. | ||
| cmd = "$(execpath :generate_metamodel_rst_bin) --rst-output $(execpath generated/index.rst) --mmd-output $(execpath generated/metamodel_classes.mmd) $(execpath //src/extensions/score_metamodel:metamodel_yaml)", |
Contributor
There was a problem hiding this comment.
wonder if the last one should be also @score_docs_as_code or if this doesn't matter here.
MaximilianSoerenPollak
approved these changes
Sep 16, 2026
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Looks good, one comment but we can address that if its ap roblem in a future PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In these genrules,
$(location ...)resolves to the same paths as$(execpath ...), so this is a behavior-preserving cleanup.locationis a legacy, context-dependent path expansion; usingexecpathmakes it explicit that these commands need paths usable by the build action.What changed
$(location ...)with$(execpath ...)in genrules that copy Needs outputs, generate metamodel documentation, and create generated documentation fixture files.