Skip to content

cryptoki: fix QNX build and tests - #196

Merged
masc2023 merged 3 commits into
eclipse-score:mainfrom
etas-contrib:fix_qnx_build_and_test_issues
Sep 9, 2026
Merged

masc2023 merged 3 commits into
eclipse-score:mainfrom
etas-contrib:fix_qnx_build_and_test_issues

Conversation

@OliverHeilwagen

Copy link
Copy Markdown
Contributor
  • Update score crates and related Bazel dependencies for QNX-compatible Rust platform resolution, regenerating the Bazel module lockfile.
  • Pin libc to the QNX-compatible 0.2.186 release.
  • Select the appropriate C++ runtime linker flags for Linux and QNX builds.
  • Use TEST_TMPDIR for QNX integration-test storage paths instead of /tmp.
  • Add a QNX-specific mtime workaround for token-object persistence tests.
  • Move optional user Bazel configuration loading after repository defaults.

@OliverHeilwagen

OliverHeilwagen commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

@ShoroukRamzy I noticed that the former fix was skipping elements, now cryptoki lib is build and tests are running under QNX. Can you please check if my changes are valid?

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 79cdf07b-ed31-42c0-9a8f-f56fbe3e55ed
Computing main repo mapping: 
DEBUG: Rule 'score_baselibs_rust+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-4kzcXcvGi9xBEEnrPOiSEvteITZMPKmK3MNgJXQIGtY="
DEBUG: Repository score_baselibs_rust+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'score_logging+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-/Q5+YfLkbMpz5PfvOkNS7qA3ehzth4emFhTcsk4q3zQ="
DEBUG: Repository score_logging+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
DEBUG: Rule 'abseil-cpp+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-m3oGQwXp/ZTRJP+mzDWFkutCtdpYj7TgfQklSqQAhts="
DEBUG: Repository abseil-cpp+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
DEBUG: Rule 'protobuf+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-w6Cp7OiTLjHDtzbi2xixxC5wcM2biBOIsm0BqnHiTKI="
DEBUG: Repository protobuf+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'grpc+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-CvN7gAlTEwtHwHW1ZoPuYL3D7aPDf8YAQZP1tWl1ggQ="
DEBUG: Repository grpc+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
INFO: Elapsed time: 11.423s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@OliverHeilwagen
OliverHeilwagen force-pushed the fix_qnx_build_and_test_issues branch from 55a0de9 to 29f23fb Compare August 27, 2026 08:35
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval August 27, 2026 08:36 — with GitHub Actions Active
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval August 27, 2026 08:36 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-196: https://eclipse-score.github.io/inc_security_crypto/pr-196/

@OliverHeilwagen
OliverHeilwagen force-pushed the fix_qnx_build_and_test_issues branch from 29f23fb to 825813b Compare August 27, 2026 11:56
@OliverHeilwagen
OliverHeilwagen force-pushed the fix_qnx_build_and_test_issues branch from 825813b to bca00cd Compare August 27, 2026 12:04
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval August 27, 2026 12:04 — with GitHub Actions Active
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval August 27, 2026 12:04 — with GitHub Actions Active
@ShoroukRamzy

Copy link
Copy Markdown
Contributor

@ShoroukRamzy I noticed that the former fix was skipping elements, now cryptoki lib is build and tests are running under QNX. Can you please check if my changes are valid?

Thank you for the PR @OliverHeilwagen, I will give my feedback soon.

@ChansAlive
ChansAlive force-pushed the fix_qnx_build_and_test_issues branch from bca00cd to 9dea46a Compare September 1, 2026 08:33
ShoroukRamzy

This comment was marked as outdated.

ShoroukRamzy

This comment was marked as outdated.

Comment thread score/cryptoki/tests/session_vs_token_objects.rs
Comment thread .bazelrc
@ShoroukRamzy

ShoroukRamzy commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Hi @OliverHeilwagen, I analyzed the test skip issue on QNX happened in this PR #191 and I agree with the current fix. The idea, score crates is configured for qnx7 triple not qnx8. That's why setting qnx8 triple in that PR led to target incompatibility, causing the tests to be silently skipped. So I agree with the current reverting to qnx7 solution as a backward-compatibility workaround at the moment. Thanks for the fix!

@ShoroukRamzy

Copy link
Copy Markdown
Contributor

Hi @OliverHeilwagen, I created these PRs to allow qnx800 target compilation for score consumer repos in the future eclipse-score/rules_rust#21
and this eclipse-score/score-crates#74

- Update score crates and related Bazel dependencies for QNX-compatible
  Rust platform resolution, regenerating the Bazel module lockfile.
- Pin libc to the QNX-compatible 0.2.186 release.
- Select the appropriate C++ runtime linker flags for Linux and QNX builds.
- Use TEST_TMPDIR for QNX integration-test storage paths instead of /tmp.
- Add a QNX-specific mtime workaround for token-object persistence tests.
- Move optional user Bazel configuration loading after repository defaults.
@OliverHeilwagen
OliverHeilwagen force-pushed the fix_qnx_build_and_test_issues branch from 9dea46a to d40b2eb Compare September 9, 2026 10:03
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval September 9, 2026 10:03 — with GitHub Actions Active
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval September 9, 2026 10:03 — with GitHub Actions Active

@ShoroukRamzy ShoroukRamzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @OliverHeilwagen.

@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval September 9, 2026 11:53 — with GitHub Actions Active
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval September 9, 2026 11:53 — with GitHub Actions Active
@masc2023
masc2023 merged commit 71e84b3 into eclipse-score:main Sep 9, 2026
11 checks passed
HeHa112 pushed a commit to iavofficial/inc_security_crypto that referenced this pull request Sep 16, 2026
* cryptoki: fix QNX build and tests

- Update score crates and related Bazel dependencies for QNX-compatible
  Rust platform resolution, regenerating the Bazel module lockfile.
- Pin libc to the QNX-compatible 0.2.186 release.
- Select the appropriate C++ runtime linker flags for Linux and QNX builds.
- Use TEST_TMPDIR for QNX integration-test storage paths instead of /tmp.
- Add a QNX-specific mtime workaround for token-object persistence tests.
- Move optional user Bazel configuration loading after repository defaults.

* cryptoki: Apply timing workaround also in case of os name qnx.

* cryptoki: Skip flaky tests also for x86_64-qnx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants