Skip to content

Resolve circular dependency bazel workaround #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaciejKaszynski merged 1 commit into from
Aug 10, 2026
Merged

Resolve circular dependency bazel workaround #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions score/launch_manager/src/daemon/src/process_group_manager/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,13 @@ cc_library(
],
)

# Header-only target for process_group_manager.hpp; used by details:process_group_manager_impl
# to break the circular header dependency without creating a Bazel cycle.
cc_library(
name = "process_group_manager_hdrs",
name = "process_group_manager",
srcs = ["process_group_manager.cpp"],
hdrs = ["process_group_manager.hpp"],
include_prefix = "score/mw/launch_manager/process_group_manager",
strip_include_prefix = "/score/launch_manager/src/daemon/src/process_group_manager",
visibility = ["//score/launch_manager/src/daemon/src/process_group_manager/details:__pkg__"],
visibility = ["//score:__subpackages__"],
deps = [
":ialive_monitor_thread",
":iprocess",
Expand All @@ -81,19 +80,11 @@ cc_library(
"//score/launch_manager/src/daemon/src/process_group_manager/details:os_handler",
"//score/launch_manager/src/daemon/src/process_group_manager/details:process_info_node",
"//score/launch_manager/src/daemon/src/process_group_manager/details:process_launcher",
"//score/launch_manager/src/daemon/src/process_group_manager/details:process_monitor",
"//score/launch_manager/src/daemon/src/process_group_manager/details:safe_process_map",
"//score/launch_manager/src/daemon/src/process_state_client:iprocess_state_notifier",
"//score/launch_manager/src/daemon/src/recovery_client",
"//score/launch_manager/src/daemon/src/watchdog:i_watchdog_if",
"@score_baselibs//score/language/futurecpp",
],
)

cc_library(
name = "process_group_manager",
visibility = ["//score:__subpackages__"],
deps = [
":process_group_manager_hdrs",
"//score/launch_manager/src/daemon/src/process_group_manager/details:process_group_manager_impl",
],
)
34 changes: 1 addition & 33 deletions score/launch_manager/src/daemon/src/process_group_manager/details/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ cc_library(

cc_library(
name = "graph",
srcs = ["graph.cpp"],
hdrs = ["graph.hpp"],
include_prefix = "score/mw/launch_manager/process_group_manager/details",
strip_include_prefix = "/score/launch_manager/src/daemon/src/process_group_manager/details",
Expand Down Expand Up @@ -206,7 +207,6 @@ cc_test(
srcs = ["graph_UT.cpp"],
deps = [
":graph",
":process_group_manager_impl",
"//score/launch_manager/src/daemon/src/configuration:configuration_adapter",
"//score/launch_manager/src/daemon/src/process_group_manager:mock_iprocess",
"@googletest//:gtest_main",
Expand Down Expand Up @@ -375,38 +375,6 @@ cc_test(
],
)

# graph.cpp, process_info_node.cpp, and process_group_manager.cpp include
# process_group_manager.hpp which in turn includes graph.hpp and process_info_node.hpp —
# circular at link time, so all three must share a target.
cc_library(
name = "process_group_manager_impl",
srcs = [
"graph.cpp",
"process_group_manager.cpp",
"process_info_node.cpp",
],
visibility = ["//score/launch_manager/src/daemon/src/process_group_manager:__pkg__"],
deps = [
":component_event_queue",
":graph",
":os_handler",
":process_info_node",
":process_launcher",
":process_monitor",
":safe_process_map",
"//score/launch_manager/src/daemon/src/common:log",
"//score/launch_manager/src/daemon/src/common/concurrency:mpmc_concurrent_queue",
"//score/launch_manager/src/daemon/src/common/concurrency:workerthread",
"//score/launch_manager/src/daemon/src/configuration:configuration_adapter",
"//score/launch_manager/src/daemon/src/osal:ipc_comms",
"//score/launch_manager/src/daemon/src/osal:semaphore",
"//score/launch_manager/src/daemon/src/process_group_manager:process_group_manager_hdrs",
"//score/launch_manager/src/daemon/src/process_state_client",
"//score/launch_manager/src/daemon/src/recovery_client",
"@score_baselibs//score/language/futurecpp",
],
)

cc_library(
name = "itransition_result_publisher",
hdrs = ["itransition_result_publisher.hpp"],
Expand Down
1 change: 0 additions & 1 deletion score/launch_manager/src/daemon/src/process_group_manager/details/graph_UT.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "score/mw/launch_manager/configuration/configuration_adapter.hpp"
#include "score/mw/launch_manager/process_group_manager/details/graph.hpp"
#include "score/mw/launch_manager/process_group_manager/mock_iprocess.hpp"
#include "score/mw/launch_manager/process_group_manager/process_group_manager.hpp"

namespace score::lcm::internal
{
Expand Down
0 ...manager/details/process_group_manager.cpp → ...s_group_manager/process_group_manager.cpp
View file
Open in desktop
File renamed without changes.
Loading