Extend crash_on_startup test to also cover comp_req__launch_man__retries_configurable by TimoSteuerwaldETAS · Pull Request #441 · eclipse-score/lifecycle

TimoSteuerwaldETAS · 2026-08-10T09:55:13Z

Part of #317
Extended test to verify if a component fails to start, the amount of retries is configurable.

github-actions · 2026-08-10T09:56:51Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 0881b0ef-1ba0-4a2d-a6f3-32ae4a822830
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (41 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (93 packages loaded, 17 targets configured)

Analyzing: target //:license-check (148 packages loaded, 2741 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6249 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6249 targets configured)

Analyzing: target //:license-check (167 packages loaded, 6298 targets configured)

Analyzing: target //:license-check (173 packages loaded, 11401 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: Found 1 target...
[16 / 16] no actions running
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.340s, Critical Path: 2.46s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-08-10T10:01:35Z

The created documentation from the pull request is available at: docu-html

WilliamRoebuck

Looks good, just a few small comments

WilliamRoebuck · 2026-08-10T10:19:16Z

+
+int main(int argc, char** argv)
+{
+    // The number of crashes before a successful startup is taken from the command line, defaulting to two.


Suggested change

// The number of crashes before a successful startup is taken from the command line, defaulting to two.

// The number of crashes before a successful startup is taken from the command line, defaulting to kDefaultCrashesUntilSuccess.

Applied, thanks.

WilliamRoebuck

Thanks, changes look good

SimonKozik

Great work! Thx for working on this.

- Strip down config - Get rid of process_crashing_on_startup_always.cpp - Decrease number of crashes and restarts, but still verify that number_of_attempts is configurable - Move process_crashing_on_startup_n_times.cpp to tests/utils/test_helper folder

github-project-automation Bot added this to LCM - Lifecycle & Health FT Aug 10, 2026

github-project-automation Bot moved this to Backlog in LCM - Lifecycle & Health FT Aug 10, 2026

TimoSteuerwaldETAS had a problem deploying to workflow-approval August 10, 2026 09:55 — with GitHub Actions Failure

TimoSteuerwaldETAS marked this pull request as ready for review August 10, 2026 09:56

TimoSteuerwaldETAS requested review from FScholPer, MaciejKaszynski, NicolasFussberger, anmittag, antonkri, pawelrutkaq and ramceb as code owners August 10, 2026 09:57

TimoSteuerwaldETAS force-pushed the feature/extend_crash_on_startup_test branch from 9a7b65d to 4a1087e Compare August 10, 2026 09:57

TimoSteuerwaldETAS had a problem deploying to workflow-approval August 10, 2026 09:57 — with GitHub Actions Failure

WilliamRoebuck reviewed Aug 10, 2026

View reviewed changes

Comment thread tests/integration/crash_on_startup/control_client_mock.cpp Outdated

WilliamRoebuck suggested changes Aug 10, 2026

View reviewed changes

SimonKozik reviewed Aug 10, 2026

View reviewed changes

Comment thread tests/integration/crash_on_startup/crash_on_startup.json

Comment thread tests/integration/crash_on_startup/process_crashing_on_startup_n_times.cpp Outdated

TimoSteuerwaldETAS had a problem deploying to workflow-approval August 10, 2026 13:29 — with GitHub Actions Failure

WilliamRoebuck approved these changes Aug 10, 2026

View reviewed changes

TimoSteuerwaldETAS requested review from SimonKozik and WilliamRoebuck August 10, 2026 13:41

WilliamRoebuck approved these changes Aug 10, 2026

View reviewed changes

TimoSteuerwaldETAS had a problem deploying to workflow-approval August 10, 2026 15:53 — with GitHub Actions Failure

SimonKozik approved these changes Aug 11, 2026

View reviewed changes

Update test binary to crash n times, depending on param

f537520

TimoSteuerwaldETAS added 11 commits August 11, 2026 09:51

Add another rt and component which crashes 5 times

7c0f399

Finish crash_on_startup test

0104f73

Requirement is no longer on feature, but on cmp level

4af6fa1

Correct config, write crash count to xml file

7bdf992

Avoid duplication

fdbf65d

Rename run targets

293fc77

Verify count of crashs in python

bfda214

Adapt test process to write crash count in report

12cb0ba

Append param to crash_count file

f1efb7f

Fix formating

ce1fc6d

TimoSteuerwaldETAS force-pushed the feature/extend_crash_on_startup_test branch from b66e64d to ce1fc6d Compare August 11, 2026 07:51

TimoSteuerwaldETAS deployed to workflow-approval August 11, 2026 07:51 — with GitHub Actions Active

MaciejKaszynski approved these changes Aug 11, 2026

View reviewed changes

MaciejKaszynski merged commit 3987d44 into eclipse-score:main Aug 11, 2026
20 checks passed

github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Aug 11, 2026

Navigation Menu

Extend crash_on_startup test to also cover comp_req__launch_man__retries_configurable - #441

Extend crash_on_startup test to also cover comp_req__launch_man__retries_configurable#441
MaciejKaszynski merged 12 commits into
eclipse-score:mainfrom
etas-contrib:feature/extend_crash_on_startup_test

TimoSteuerwaldETAS commented Aug 10, 2026

Uh oh!

github-actions Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

Uh oh!

WilliamRoebuck left a comment

Uh oh!

Uh oh!

Uh oh!

WilliamRoebuck Aug 10, 2026

Uh oh!

TimoSteuerwaldETAS Aug 10, 2026

Uh oh!

Uh oh!

Uh oh!

WilliamRoebuck left a comment

Uh oh!

SimonKozik left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	// The number of crashes before a successful startup is taken from the command line, defaulting to two.
	// The number of crashes before a successful startup is taken from the command line, defaulting to kDefaultCrashesUntilSuccess.

Conversation

TimoSteuerwaldETAS commented Aug 10, 2026

Uh oh!

github-actions Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

Uh oh!

WilliamRoebuck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

WilliamRoebuck Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

TimoSteuerwaldETAS Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

WilliamRoebuck left a comment

Choose a reason for hiding this comment

Uh oh!

SimonKozik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Aug 10, 2026 •

edited

Loading