Skip to content

Add tests which are verifying comp_req__launch_man__launcher_exit_shutdown - #450

Merged
NicolasFussberger merged 13 commits into
eclipse-score:mainfrom
etas-contrib:feature/shutdown_tests
Aug 25, 2026
Merged

NicolasFussberger merged 13 commits into
eclipse-score:mainfrom
etas-contrib:feature/shutdown_tests

Conversation

@TimoSteuerwaldETAS

@TimoSteuerwaldETAS TimoSteuerwaldETAS commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Part of #317

comp_req__launch_man__launcher_exit_shutdown
The Launch Manager shall exit after performing shutdown operation by
stopping all the Processes <Process> it owns in the dependency order when requested.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 0ffa1d49-83ac-4b55-8bdf-834e537a0277
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (41 packages loaded, 10 targets configured)

Analyzing: target //:license-check (89 packages loaded, 10 targets configured)

Analyzing: target //:license-check (147 packages loaded, 1926 targets configured)

Analyzing: target //:license-check (160 packages loaded, 4720 targets configured)

Analyzing: target //:license-check (162 packages loaded, 9153 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9451 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9451 targets configured)

Analyzing: target //:license-check (176 packages loaded, 11463 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11589 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 23.199s, Critical Path: 0.30s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown
Contributor

The created documentation from the pull request is available at: docu-html

@WilliamRoebuck WilliamRoebuck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the UTs need updating since #455 but looks good other than that. I thought we could also use the Off run target timeout instead of the max termination timeout workaround but I think that would need a few more changes elsewhere (run targets don't actually store their config). I've updated #496 to track this.

@TimoSteuerwaldETAS
TimoSteuerwaldETAS deployed to workflow-approval August 24, 2026 11:17 — with GitHub Actions Active
@TimoSteuerwaldETAS

Copy link
Copy Markdown
Contributor Author

@WilliamRoebuck After discussion with @NicolasFussberger I have changed the implementation to use the transition timeout of the Off Run Target. However, as this is not a complete support of the transition timeout as described in #496 , I have not set this issue to done.

Comment thread score/launch_manager/src/daemon/src/process_group_manager/details/graph.cpp Outdated
Comment thread score/launch_manager/src/daemon/src/process_group_manager/details/graph_UT.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants