Use score::cpp::jthread where applicable - #632
Open
paulquiring wants to merge 1 commit into
Open
paulquiring wants to merge 1 commit into
paulquiring wants to merge 1 commit into
Conversation
paulquiring
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
September 14, 2026 12:27
paulquiring
requested a deployment
to
workflow-approval
September 14, 2026 12:27 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
September 14, 2026 12:27 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
MaciejKaszynski
requested changes
Sep 14, 2026
MaciejKaszynski
left a comment
MaciejKaszynski
left a comment
Contributor
There was a problem hiding this comment.
I think there are also these files that use std::thread:
score/launch_manager/src/daemon/src/alive_monitor/details/daemon/AliveMonitorImpl.hppscore/launch_manager/src/daemon/src/common/concurrency/thread_pool.hpp
Or could be done in a later PR.
| score::mw::lifecycle::internal::osal::OsalReturnType::kSuccess == init_result, | ||
| "ControlClient semaphore initialization failed"); | ||
| ipc_response_thread_ = std::make_unique<std::thread>(&ControlClientImpl::run, this); | ||
| ipc_response_thread_ = score::cpp::jthread([this](score::cpp::stop_token stop_token) { |
Contributor
There was a problem hiding this comment.
I think it should be able to just give the forward the args like a normal std::thread https://github.com/eclipse-score/baselibs/blob/e1d74ac2183338be0e2f65b0d1f807a0a393a07f/score/language/futurecpp/include/score/jthread.hpp#L136. Then we don't need the lambda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
score::cpp::jthread is used where applicable