Use milliseconds directly in launch manager config schema - #637
Merged
NicolasFussberger merged 2 commits intoSep 16, 2026
Merged
NicolasFussberger merged 2 commits into
NicolasFussberger merged 2 commits into
Conversation
Rename the 8 user-facing timing fields in launch_manager.schema.json from seconds (number) to their _ms equivalents (integer), matching the flatbuffer schema migration done in eclipse-score#388: - reporting_cycle -> reporting_cycle_ms - polling_interval -> polling_interval_ms - delay_before_restart -> delay_before_restart_ms - ready_timeout -> ready_timeout_ms - shutdown_timeout -> shutdown_timeout_ms - transition_timeout -> transition_timeout_ms - evaluation_cycle -> evaluation_cycle_ms - max_timeout -> max_timeout_ms Remove the now-redundant sec_to_ms() conversion (and its validation) from lifecycle_config.py, since the JSON schema's type/minimum/maximum constraints already reject negative, non-integer and overflowing values. Update all example configs, integration test fixtures, the gen_lifecycle_config.py test helper, and documentation to use the new field names and millisecond values. This was previously postponed pending removal of legacy config support, which has since happened in eclipse-score#388. Closes eclipse-score#635
shegazyy
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
September 15, 2026 14:31
shegazyy
requested a deployment
to
workflow-approval
September 15, 2026 14:31 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
September 15, 2026 14:31 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
|
Documentation preview for this pull request is available at: |
Contributor
|
Thanks for your contribution. Looks good to me! Do you also want to take a look @MaciejKaszynski ? |
NicolasFussberger
approved these changes
Sep 16, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in LCM - Lifecycle & Health FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the 8 user-facing timing fields in launch_manager.schema.json from seconds (number) to their _ms equivalents (integer), matching the flatbuffer schema migration done in #388:
Remove the now-redundant sec_to_ms() conversion (and its validation) from lifecycle_config.py, since the JSON schema's type/minimum/maximum constraints already reject negative, non-integer and overflowing values. Update all example configs, integration test fixtures, the gen_lifecycle_config.py test helper, and documentation to use the new field names and millisecond values.
This was previously postponed pending removal of legacy config support, which has since happened in #388.
Closes #635