Type Sanitizer Implementation - #44
Merged
nradakovic merged 4 commits intoSep 16, 2026
Merged
Conversation
armando-martins
commented
Sep 16, 2026
| "@score_cpp_policies//sanitizers/features:tysan", | ||
| ], | ||
| llvm_version = "19.1.7", | ||
| llvm_version = "21.1.8", |
Contributor
Author
There was a problem hiding this comment.
In the llvm version 19.1.7, the TySan doesn't exist yet, so we bump the version here to 21.1.8.
This is a point that should be aligned with the rest of S-Core repos. It was just added here to show that the implementation is correct and the tests pass.
armando-martins
commented
Sep 16, 2026
| | LSan + TSan | ❌ No | TSan has built-in leak detection; enabling both causes runtime conflicts | | ||
| | TySan + ASan | ❌ No | Incompatible shadow-memory runtimes | | ||
| | TySan + LSan | ❌ No | Incompatible shadow-memory runtimes | | ||
| | TySan + TSan | ❌ No | Incompatible shadow-memory runtimes | |
Contributor
Author
There was a problem hiding this comment.
We don't refer the UBSan+TySan because they work together. But as TySan is recent, and not even the exitcode or halt_on_error works correctly, we will keep it running separated from UBSan.
armando-martins
commented
Sep 16, 2026
| # TySan (Clang/LLVM only — no GCC variant available). | ||
| build:feature_only_tysan --extra_toolchains=@llvm_toolchain//:cc-toolchain-x86_64-linux | ||
| build:feature_only_tysan --features=score_tysan | ||
| test:feature_only_tysan --test_env=TYSAN_OPTIONS=exitcode=55:halt_on_error=1 |
Contributor
Author
There was a problem hiding this comment.
in the future the "halt_on_error" and "existcode" should exist, so we keep it as this by now, as it doesn't break nothing.
armando-martins
force-pushed
the
ajfm_tysan_implementation
branch
from
September 16, 2026 09:14
5f78102 to
2c1360a
Compare
armando-martins
marked this pull request as ready for review
September 16, 2026 09:24
armando-martins
force-pushed
the
ajfm_tysan_implementation
branch
from
September 16, 2026 13:34
2c1360a to
46b8665
Compare
nradakovic
self-requested a review
September 16, 2026 13:40
nradakovic
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current concerns
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #34