You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make sure to link this issue by including Closes #228 in PR
What
sanitizers.yml's matrix only runs asan_ubsan_lsan — TSan is needed also.
Ran TSan+UBSan manually against score/time_daemon/... returned 2 failures,
both ThreadSanitizer: data race.
ptp_control_flow_divider_test — in EventDrivenMachine's stop_token wait path
(event_driven_machine.cpp:28). Self-pipe-wakeup-vs-teardown races are a common real bug shape
here — looks like a genuine issue, not a false positive.
job_runner_test — in score_baselibs' Meyer-singleton logging init (GetSingletonWithFence)
— looks more like a known TSan false-positive on fence-based lock-free init, not something to
fix in this repo.
Acceptance Criteria
Add TSan to sanitizers.yml's matrix
Confirm and fix/suppress findings in score/time_daemon/ submodule only
Important
Make sure to link this issue by including
Closes #228in PRWhat
sanitizers.yml's matrix only runsasan_ubsan_lsan— TSan is needed also.Ran TSan+UBSan manually against
score/time_daemon/...returned 2 failures,both
ThreadSanitizer: data race.ptp_control_flow_divider_test— inEventDrivenMachine's stop_token wait path(
event_driven_machine.cpp:28). Self-pipe-wakeup-vs-teardown races are a common real bug shapehere — looks like a genuine issue, not a false positive.
job_runner_test— inscore_baselibs' Meyer-singleton logging init (GetSingletonWithFence)— looks more like a known TSan false-positive on fence-based lock-free init, not something to
fix in this repo.
Acceptance Criteria
sanitizers.yml's matrixscore/time_daemon/submodule onlyReferences