Skip to content

add time_daemon component requirements - #153

Open
ryan-steel wants to merge 7 commits into
eclipse-score:mainfrom
etas-contrib:add-time_daemon-component-requirements
Open

ryan-steel wants to merge 7 commits into
eclipse-score:mainfrom
etas-contrib:add-time_daemon-component-requirements

Conversation

@ryan-steel

@ryan-steel ryan-steel commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Improvement

Description

Add initial component documentation for time_daemon following S-CORE process

Related ticket

Part of #64

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: ac6b7030-7860-4a48-86a9-55ca3e77d8cc
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'platforms', the root module requires module version platforms@1.0.0, but got platforms@1.1.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_platform', the root module requires module version score_platform@0.7.1, but got score_platform@0.7.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_oci', the root module requires module version rules_oci@2.2.7, but got rules_oci@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/time/time/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/time/time/BUILD
INFO: Elapsed time: 14.179s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial S-CORE process documentation scaffolding for the score/time_daemon component, establishing requirement artifacts and architecture boilerplate to support traceability and future inspection.

Changes:

  • Added component requirements document and requirements inspection checklist under score/time_daemon/docs/requirements/.
  • Added architecture boilerplate and architecture inspection checklist under score/time_daemon/docs/architecture/.
  • Added component-level docs entry point and toctree wiring for requirements + architecture.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
score/time_daemon/docs/requirements/requirements.rst Introduces initial comp_req entries for time_daemon (draft/invalid baseline).
score/time_daemon/docs/requirements/index.rst Adds requirements section toctree for the component docs.
score/time_daemon/docs/requirements/chklst_req_inspection.rst Adds requirements inspection checklist template for the component.
score/time_daemon/docs/index.rst Adds the component documentation landing page linking requirements and architecture.
score/time_daemon/docs/architecture/index.rst Adds architecture section toctree for the component docs.
score/time_daemon/docs/architecture/component_architecture.rst Adds component architecture boilerplate, including comp and static/dynamic view placeholders.
score/time_daemon/docs/architecture/chklst_arc_inspection.rst Adds architecture inspection checklist template for the component.
Suppressed comments (2)

score/time_daemon/docs/architecture/component_architecture.rst:102

  • The "comp_arc_dyn" need has an empty ":fulfils:" option. If requirement allocation is not decided yet, avoid empty relation fields to prevent Sphinx-Needs warnings/errors.
   :belongs_to: comp__time_daemon
   :fulfils:

score/time_daemon/docs/architecture/chklst_arc_inspection.rst:178

  • Extra quote characters in the note: ""n/a"" should be "n/a".
Note: If a Review ID is not applicable for your architecture, then state ""n/a" in status and comment accordingly in remarks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread score/time_daemon/docs/index.rst Outdated
Comment thread score/time_daemon/docs/architecture/component_architecture.rst Outdated
Comment thread score/time_daemon/docs/architecture/component_architecture.rst Outdated
Comment thread score/time_daemon/docs/architecture/component_architecture.rst Outdated
Comment thread score/time_daemon/docs/architecture/chklst_arc_inspection.rst Outdated
Comment thread score/time_daemon/docs/architecture/component_architecture.rst Outdated
Comment thread score/time_daemon/docs/requirements/chklst_req_inspection.rst
Comment thread score/time_daemon/docs/requirements/requirements.rst Outdated
@ryan-steel
ryan-steel force-pushed the add-time_daemon-component-requirements branch from 20e33f8 to 2c79177 Compare August 6, 2026 15:11
@ryan-steel
ryan-steel force-pushed the add-time_daemon-component-requirements branch from 55625e2 to 2c79177 Compare August 7, 2026 13:53
@ryan-steel
ryan-steel force-pushed the add-time_daemon-component-requirements branch 2 times, most recently from 2c79177 to 210b4ce Compare August 13, 2026 10:25
@ryan-steel
ryan-steel marked this pull request as draft August 13, 2026 11:57
Comment thread score/time_daemon/docs/requirements/requirements.rst Outdated
Comment thread score/time_daemon/docs/requirements/requirements.rst Outdated
Comment thread score/time_daemon/docs/architecture/component_architecture.rst Outdated
Comment thread score/time_daemon/docs/requirements/requirements.rst Outdated
@ryan-steel
ryan-steel force-pushed the add-time_daemon-component-requirements branch from 210b4ce to c8600ef Compare August 14, 2026 09:34
@ryan-steel
ryan-steel force-pushed the add-time_daemon-component-requirements branch from b6ec48f to de42f18 Compare August 19, 2026 13:30
@ryan-steel
ryan-steel marked this pull request as ready for review August 19, 2026 13:42
@ryan-steel
ryan-steel marked this pull request as draft August 19, 2026 16:02
@ryan-steel
ryan-steel force-pushed the add-time_daemon-component-requirements branch from e5b427d to 6c5353e Compare August 25, 2026 08:54
@ryan-steel
ryan-steel force-pushed the add-time_daemon-component-requirements branch from f9fcb3c to 9835a27 Compare August 28, 2026 16:19
Comment thread score/time_daemon/docs/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated

@BjoernAtBosch BjoernAtBosch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aligned the reqs a bit with the recent changes of those of time_slave and prepared to make the fixed "magic number" configurable. Hope, that's it.

Comment thread score/time_daemon/docs/index.rst Outdated
Comment thread score/time_daemon/docs/index.rst Outdated
Comment thread score/time_daemon/docs/index.rst Outdated
Comment thread score/time_daemon/docs/index.rst
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated
Comment thread score/time_daemon/docs/requirements/index.rst Outdated

@BjoernAtBosch BjoernAtBosch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch is waiting to be deployed

1 waiting deployment
workflow-approval ad94ac98 Waiting Sep 21, 2026 by ryan-steel via qnx-build (arm64-qnx) / approval #792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants