[FEATURE][Timpani-n] Store full task list and add workload polling loop - #131
Merged
basheerFZ merged 6 commits intoJun 1, 2026
Merged
Conversation
- Add TaskInfo domain type mirroring struct task_info (schedinfo.h), without runtime fields (pid/pidfd); derives Debug, Clone, PartialEq - Expand SchedInfo with tasks: Vec<TaskInfo> and received_at: Instant, as a substitute for sequence number. drop redundant task_count field - Implement PartialEq for SchedInfo excluding received_at (content-only equality); add content_changed(), is_full_replacement(), task_count() - Add task_from_proto() converter at the proto/domain boundary in lib.rs - Convert and store the full task list from GetSchedInfo response - Replace cancel.cancelled().await stub with a 2s polling loop that re-fetches GetSchedInfo and detects workload changes; NotReady keeps the current schedule running (no teardown); full teardown+reinit is a TODO pending the task module - Add unit tests for SchedInfo change-detection semantics (100% coverage)
…timpani into development_0.5
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Timpani-N’s runtime schedule state to store the full per-node task list (as a proto-free domain type) and replaces the shutdown-only wait with a periodic (2s) polling loop against GetSchedInfo to detect workload replacements/updates via content comparison (ignoring received_at).
Changes:
- Introduces
TaskInfoand stores the fullVec<TaskInfo>inSchedInfo, adding content-based comparison helpers and unit tests. - Adds a proto→domain boundary conversion (
task_from_proto) and updates startup logging to use the domain task list. - Implements a 2-second workload polling loop that keeps the current schedule on
NotReadyand updates runtime schedule state on detected changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
timpani_rust/timpani-n/src/lib.rs |
Adds proto→domain task conversion and a periodic polling loop to detect and apply schedule changes. |
timpani_rust/timpani-n/src/context/mod.rs |
Adds TaskInfo, expands SchedInfo to store full tasks, implements content equality helpers, and adds unit tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add task/mod.rs: BpfState, TimeTrigger, init_task_list/teardown_task_list implementing Linux RT scheduling setup (SCHED_DEADLINE / SCHED_FIFO), CPU affinity via CpuSet, and BPF fd management per task - Add sched/mod.rs extensions: set_cpu_affinity, get_cpu_affinity, set_sched_attr, get_sched_attr with 15 unit tests (affinity A1-A2, schedattr B1-B3, init_task_list C1-C7, polling D1-D4) - Apply code review fixes to lib.rs and context/mod.rs: * Replace .expect() in polling loop with recoverable warn+continue * Handle None sched_info in polling loop (restore from latest poll) * Advance received_at even when workload content is unchanged * Fix misleading cpu_affinity doc comment (uint64 on wire, not int64) * Fix TaskInfo::name doc (limit enforced by helpers, not by the type)
The CI coverage check was failing with 76.0% combined (below 80%). Two root causes: 1. Untestable entry points counted in denominator: - timpani-n/src/main.rs: 0/11 lines (binary entry point, no unit-testable logic) - timpani-o/src/main.rs: 2/85 lines (server startup, cannot be unit-tested) - timpani-n/tests/*: ignored integration tests inflate miss count Excluding these from coverage: 872/1047 → 873/962 lines in scope. 2. Parallel test execution caused ptrace to miss covered lines: Sched tests manipulate CPU affinity on the current PID; running them concurrently in ptrace mode causes instrumentation to drop hits. Fix: add args = ["--test-threads", "1"] in tarpaulin.toml. Result: local combined coverage 90.75% (was 76.0% in CI, 83.29% without the args fix). Adds --config tarpaulin.toml to test_coverage.sh.
basheerFZ
merged commit Jun 1, 2026
7148f2b
into
eclipse-timpani:development_0.5
16 of 17 checks passed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store the full task list in timpani-n Rust schedule state and add a 2-second polling loop to detect workload updates from GetSchedInfo.
Changes
Issues
Notes
Full teardown and reinitialization for schedule replacement is intentionally left as follow-up work.