Skip to content

Conversation

@jinmannwong
Copy link
Collaborator

Description

Fixes bug on merging thermofeel configs for parameters that required inst and accum inputs and those which only required inst input. Now in config generation, by default set accum source in global inputs config to null and this is overridden inside the parameter config by those which required accum inputs.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@jinmannwong jinmannwong requested a review from oiffrig December 18, 2025 13:03
@jinmannwong jinmannwong merged commit 998beed into develop Dec 18, 2025
2 checks passed
@jinmannwong jinmannwong deleted the fix/thermofeel-merge branch December 18, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants