Repository navigation
Skip @type inside docblock description in blink TypeToVarTag - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports TypeToVarTagFixer #81 to blink. blink's
TypeToVarTagrewrote every@typeto@var, including occurrences inside a docblock description (e.g. the sentence "Matches only @type at the start of a line"). ECS fixed this in #81 to only match@typeat the start of a doc line.Change
typeTagRe:@type\b->(?m)^(\s*(?:/\*{1,2}|\*)?\s*)@type\b, replacement${1}@var, mirroring the PHP regex.Result
This was the last
--blinkdivergence from ECS on this repository:--blinkparity on this repo: 0 (was 1)build, vet, gofmt -s, modernize, golangci-lint, go test all pass.