Repository navigation
Replace tomasvotruba/unused-public with shipmonk/dead-code-detector - #150
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
replace-unused-public-with-dead-code-detector
branch
3 times, most recently
from
October 7, 2026 08:43
3c46ca8 to
ecc3398
Compare
TomasVotruba
force-pushed
the
replace-unused-public-with-dead-code-detector
branch
from
October 7, 2026 08:49
ecc3398 to
e056c00
Compare
TomasVotruba
force-pushed
the
replace-unused-public-with-dead-code-detector
branch
from
October 7, 2026 08:50
e056c00 to
40ee54f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the dev dependency
tomasvotruba/unused-publicforshipmonk/dead-code-detector.composer.json: remove unused-public, add shipmonk/dead-code-detector (auto-registered via phpstan/extension-installer).phpstan.neon: drop theunused_public:block, include a baseline.phpstan-baseline.neon: new baseline capturing the dead-code-detector findings. These are DI container autowired constructors (and a few dynamically called interface methods) that the detector cannot trace through the Entropy container, so they are false positives rather than removable code.CI status: PHPStan, Composer Validate, Coding Standard, Tests and Check Active Classes pass. The Rector job fails, but that failure is pre-existing and unrelated to this change - Rector 2.6.7 flags 5 files under
packages/coding-standardand warns thatDeprecatedAnnotationToDeprecatedAttributeRectorin the skip list is deprecated. None of these touch the dependency swap and they reproduce onmain.