Repository navigation
Ratchet laravel parity gate to 2.7% - #151
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowers the laravel parity gate to reflect the real improvement from the merged laravel fixes (#145/#147/#148/#149).
Measured on a fresh laravel/framework clone (src + tests, all prepared sets): 77 of 3042 files differ = 2.53%. The gate was still 4% (set before those fixes landed), so this ratchets it to 2.7% - just above actual, with ~5 files of margin for laravel/framework's daily drift (CI re-clones main each run).
No code change; gate-only. The remaining divergences are dominated by php-cs-fixer ordering artifacts (constructor single-param wrap, docblock empty-shell) that can't be matched without bug-for-bug emulation that would risk the strict rector 1:1 gate, plus a scattered tail (blade templates, attribute-array, license headers) - so 2.7% is near the gate-safe floor.