Repository navigation
Make deprecated withPhpCsFixerSets() accept legacy args without crashing - #155
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ecsphp/ecs#331
The deprecated
withPhpCsFixerSets()took no parameters, so calling it with the former named arguments (e.g.->withPhpCsFixerSets(perCS30: true)) threw an "unknown named parameter" error instead of printing the deprecation warning.Added a
bool ...$setsvariadic so legacy calls are swallowed gracefully and the deprecation warning is shown as intended.RemoveUnusedPublicMethodParameterRectoron the builder, since the variadic intentionally exists only to absorb legacy args