Repository navigation
[ax] Merge four SkipCriteria resolvers into one - #156
Merged
Merged
Conversation
TomasVotruba
changed the title
TomasVotruba
marked this pull request as ready for review
October 7, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkippedPathsResolver,SkippedClassResolver,SkippedClassAndCodesResolverandSkippedMessagesResolverwere four near-identical classes: each readOption::SKIP, looped, shifted int keys to=> nulland filtered by a single predicate. The SKIP parameter was parsed and cached four separate times.Folds them into one
SkippedCriteriaResolverthat parses SKIP once into four buckets, exposed viaresolvePaths(),resolveClasses(),resolveClassAndCodes()andresolveMessages(). Each predicate is kept verbatim, so behavior is unchanged.Callers updated:
Skipper,BlinkConfigDumper,ListCheckersCommandand the existing paths resolver test.All 316 tests pass; Rector and ECS clean on the changed files.