Repository navigation
Collapse blank lines between call args in blink to match MethodArgumentSpaceFixer - #164
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#160 regressed mautic blink parity (from 3 to 9 differing files, over the 0.07% gate). It made blink's shared
reflowParenalways preserve author-added blank lines between arguments. But php-cs-fixer'sMethodArgumentSpaceFixercollapses those blanks, so blink kept 6 blank lines the PHP engine drops.Bisect: parity was green through #159 (3 pre-existing diffs, under the gate) and first failed on #160.
Fix
Restore the per-rule distinction that matches each php-cs-fixer rule:
method_argument_spacecollapses blank lines between arguments (matchesMethodArgumentSpaceFixer).method_argument_spacestill collapses the net output for promoted constructors, so the standalone-line rules keep their preserving behavior without breaking parity.Verification
Full parity against mautic/mautic (psr12 + perCs + common + standaloneLine + cleanCode): 4548 files, 3 differing (0.066%, under the 0.07% gate). The 3 remaining diffs are pre-existing and unrelated (list-assignment reflow, two view-template indents).
go build,go vet,go test ./..., andgofmtall clean.