Skip to content

Collapse blank lines between call args in blink to match MethodArgumentSpaceFixer - #164

Merged
TomasVotruba merged 1 commit into
mainfrom
tv-fix-mautic-parity-arg-reflow
Oct 8, 2026
Merged

TomasVotruba merged 1 commit into
mainfrom
tv-fix-mautic-parity-arg-reflow

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Problem

#160 regressed mautic blink parity (from 3 to 9 differing files, over the 0.07% gate). It made blink's shared reflowParen always preserve author-added blank lines between arguments. But php-cs-fixer's MethodArgumentSpaceFixer collapses those blanks, so blink kept 6 blank lines the PHP engine drops.

Bisect: parity was green through #159 (3 pre-existing diffs, under the gate) and first failed on #160.

Fix

Restore the per-rule distinction that matches each php-cs-fixer rule:

  • method_argument_space collapses blank lines between arguments (matches MethodArgumentSpaceFixer).
  • array and standalone-line reflows keep them (match their fixers in isolation).

method_argument_space still collapses the net output for promoted constructors, so the standalone-line rules keep their preserving behavior without breaking parity.

Verification

Full parity against mautic/mautic (psr12 + perCs + common + standaloneLine + cleanCode): 4548 files, 3 differing (0.066%, under the 0.07% gate). The 3 remaining diffs are pre-existing and unrelated (list-assignment reflow, two view-template indents).

go build, go vet, go test ./..., and gofmt all clean.

@TomasVotruba
TomasVotruba merged commit e215b01 into main Oct 8, 2026
19 checks passed
@TomasVotruba
TomasVotruba deleted the tv-fix-mautic-parity-arg-reflow branch October 8, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant