Skip to content

Fix blink spacing for new Enum() and yield from () to match ECS - #165

Merged
TomasVotruba merged 1 commit into
mainfrom
blink-parity-enum-yield-from
Oct 8, 2026
Merged

TomasVotruba merged 1 commit into
mainfrom
blink-parity-enum-yield-from

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Two blink spacing divergences from the PHP engine, found via the laravel/framework parity gate:

  • new Enum($x) gained a stray space (new Enum ($x)): enum is lexed as a keyword, and SingleSpaceAroundConstruct treated it as a construct before (. enum never opens a ( as a declaration keyword, so it is now treated as a class reference like new static( / new class(.
  • yield from (expr) lost its space (yield from(expr)): NoSpacesAfterFunctionName treated from as a called function. It now skips from when preceded by yield.

Both are covered by fixtures mirroring php-cs-fixer behaviour. Reduces laravel parity diffs by 3 files.

@TomasVotruba
TomasVotruba enabled auto-merge (squash) October 8, 2026 12:59
@TomasVotruba
TomasVotruba disabled auto-merge October 8, 2026 13:02
@TomasVotruba
TomasVotruba merged commit 74de88a into main Oct 8, 2026
19 checks passed
@TomasVotruba
TomasVotruba deleted the blink-parity-enum-yield-from branch October 8, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant