Repository navigation
Reject mutually exclusive checkers in blink ECS config - #167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports ECS's ConflictingCheckersCompilerPass to blink. When a dumped ECS config loads both halves of a mutually exclusive checker group (e.g. YodaStyleFixer and DisallowYodaComparisonSniff, which do the opposite of each other), blink now rejects the config with a clear error instead of running both, matching ECS's behaviour. A checker disabled via skip does not count as loaded.
The conflict table mirrors ECS's CONFLICTING_CHECKER_GROUPS. Covered by a unit test for the conflict, the skip escape hatch, and the single-checker case.