Repository navigation
Separate keyword-typed properties in blink class attribute spacing - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassAttributesSeparation did not recognise a property whose type is a keyword (e.g.
private array $b,private static $c): the member-type classifier hit the keyword switch's default and returned 'unknown', so no blank line was inserted before it.Keyword types now fall through to the variable scan, so such properties are classified as properties and separated by one blank line, matching ECS.
Found via the rectorphp/rector parity run, where it accounted for the large majority of divergences (blink was collapsing blank lines between typed properties). Covered by a fixture.