Repository navigation
Model 5 fixer configs in blink instead of ignoring them - #208
Merged
Merged
Conversation
blink reported these as applied with built-in behaviour (config not modelled): make each a ConfigurableFixer honoring its php-cs-fixer options. - modifier_keywords: elements subset (const/property/method) - single_import_per_statement: group_to_single_imports (default expands groups) - nullable_type_declaration: syntax union (?T -> T|null) - blank_lines_before_namespace: min_line_breaks / max_line_breaks - operator_linebreak: only_booleans and position=end
TomasVotruba
force-pushed
the
blink-model-fixer-configs
branch
from
October 14, 2026 08:50
e013597 to
244e56a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A blink run on an ECS config reports some rules as:
These 5 fixers did not implement
ConfigurableFixer, so their options (even the resolved defaults php-cs-fixer dumps) were dropped and reported as ignored.Change
Each fixer now implements
ConfigurableFixerand honors its php-cs-fixer options:modifier_keywords:elementssubset (const / property / method)single_import_per_statement:group_to_single_imports- the default (true) now expands brace group importsuse A\{B, C};; false keeps the groupnullable_type_declaration:syntax: unionrewrites?TtoT|nullblank_lines_before_namespace:min_line_breaks/max_line_breaksoperator_linebreak:only_booleansandposition: endWith these wired up,
resolveECSresolves the config instead of adding them toConfigIgnored.Tests
Added a
_config_test.goper fixer covering default and non-default options; fullgo test ./...passes.