Repository navigation
Skip MethodChainingNewlineFixer in boolean and comparison chains - #90
Merged
TomasVotruba merged 2 commits intoSep 29, 2026
Merged
Conversation
TomasVotruba
force-pushed
the
skip-method-chain-newline-in-boolean-comparison
branch
from
September 29, 2026 08:25
39d596f to
b2e36a3
Compare
TomasVotruba
enabled auto-merge (squash)
September 29, 2026 08:25
TomasVotruba
deleted the
skip-method-chain-newline-in-boolean-comparison
branch
September 29, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49
MethodChainingNewlineFixernewlined any single-line)->method()chain, including ones used as boolean or comparison operands. This split readable conditions like:into an uglier form with
->yes()pushed onto its own line.Change
ChainMethodCallAnalyzer::isPartOfBooleanOrComparison()scans left and right from the->at the chain's own bracket depth (skips nested()/[], stops at the enclosing bracket,;,{,}). Returns true when a boolean (&&,||,and,or,xor) or comparison (===,!==,==,!=,<=>,<=,>=,<,>) operator sits at that depth.MethodChainingNewlineFixerskips the newline when the chain is such an operand.Plain chains, assignments, and arg/array chains are unaffected - still newlined as before.
Added two skip fixtures covering both examples from the issue.