Repository navigation
Expose bin/blink in the published composer bin - #94
Merged
Merged
Conversation
The deployed composer.json listed only bin/ecs, so vendor/bin/blink was never symlinked on install. Add bin/blink so it is available after composer require.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #92 and #93. The deployed
composer.json(build/target-repository/composer.json) listed onlybin/ecs, sovendor/bin/blinkwas never symlinked when the package is installed -vendor/bin/blinkcame back "no such file or directory".Add
bin/blinkto the published bin array so it is available aftercomposer require symplify/easy-coding-standard.The wrapper and the per-platform
bin/blink-<os>-<arch>binaries already ship (from #93), so once this is in a release,vendor/bin/blinkresolves to the wrapper and execs the bundled binary for the current platform.