Repository navigation
Drop standalone blink bin, make --blink the only entry point - #96
Merged
Merged
Conversation
Running vendor/bin/blink directly scans the whole working directory with all fixers and ignores the project ecs.php, which is easy to trigger by accident. Remove it so blink is reached only through 'ecs check --blink', which feeds the resolved ecs.php (paths, skips, rules) to the binary. - remove bin/blink from the dev and published composer bin, delete the wrapper - EcsGoBinaryLocator drops the vendor/bin/blink lookup - turbo CI builds blink from the local blink/ module instead of cloning the external repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
vendor/bin/blinkdirectly defaults to the whole working directory with every fixer and ignores the projectecs.php(paths, skips, rule set), so it is easy to launch a full-tree run by accident. This removes the standalone bin and leavesecs check --blinkas the only entry point, which dumps the resolvedecs.phpto JSON and hands it to the binary.Changes
bin/blinkfrom the devcomposer.jsonand the publishedbuild/target-repository/composer.json, and delete thebin/blinkwrapper - no morevendor/bin/blink.EcsGoBinaryLocatordrops the now-deadvendor/bin/blinklookup; it still resolves the bundledbin/blink-<platform>, theECS_TURBO_BINoverride, andblinkon PATH.turbo.yaml(the--blinke2e test) builds blink from the localblink/module instead of cloning the externalTomasVotruba/ecs-go, matching the release build from Build blink binaries from local blink/ module in release #93.--blinkkeeps working via the bundled per-platform binaries. PHPStan, ECS, Rector, and the Turbo tests pass locally.