Repository navigation
Add RemoveParamDescriptionDuplicateNameFixer for PHP and blink - #99
Merged
Merged
Conversation
Strip a @PARAM description that only repeats the parameter name, ignoring case, whitespace and trailing punctuation. Ported to the blink Go engine and added to the common set.
Add the fixer to DocblockLevel::RULES so ECS's common prepared set runs it, matching blink's common set for 1:1 parity. Point the blink rule's source at ecs-src, add it to ecsSrcOnlyFixers, set priority -37, and refresh the rule-count snapshots.
vitek-rostislav
added a commit
to shopsys/shopsys
that referenced
this pull request
Oct 7, 2026
- coding standards now report such descriptions since ecsphp/ecs-src#99
1 task done
ShopsysBot
pushed a commit
to shopsys/framework
that referenced
this pull request
Oct 7, 2026
- coding standards now report such descriptions since ecsphp/ecs-src#99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a custom PHP-CS-Fixer rule that removes a
@paramdescription when it only duplicates the parameter name, ignoring case, whitespace and trailing punctuation.A genuine description (e.g.
@param int $id Numeric identifier of the record) is left untouched.What's included
RemoveParamDescriptionDuplicateNameFixer(extendsAbstractDocBlockFixer) plus PHPUnit fixtures.DocblockLevel::RULES, so it is part of thecommonprepared set (and the docblock level).All(), priority -37, added to the common set andecsSrcOnlyFixers, with Go unit tests.ecs-rules.txt,ecs-all-fixers.txt, blink README).Checks
Note: the
fixer_sourcesjob HEAD-checks each rule's source URL againstecs-srcmain. It stays red until this PR is merged, because the fixer file only lands onmainon merge; it goes green afterwards.