fix(magnetostatic): unbreak main's fmt and clippy gates#696
Merged
Conversation
`Grid-free magnetostatic oracle` (#692) landed unformatted, so `cargo fmt --check` fails on main and every open PR is red for a reason that has nothing to do with its own diff. Pure `rustfmt --edition 2021` output, no hand edits. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Choji has used up today's reviewsYour team has reached the free plan's limit of 5 reviews per day, so Choji stepped aside on this pull request. That's a plan limit, not a reflection of the change itself. Your free reviews reset tomorrow. To have Choji review every push without waiting, upgrade to Pro for unlimited reviews. You're on the free plan · 5 reviews/day. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The same PR (#692) also trips clippy 1.95's manual_is_multiple_of, which is the next gate after the format check — so main fails clippy too, and fixing only the formatting just moved the red one step down the job. `k % 2 == 0` -> `k.is_multiple_of(2)` on usize: identical behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Grid-free magnetostatic oracle + fix cancelling multilayer coils(#692,34f31195) landed with two CI gates unsatisfied, somainitself is red and every open PR fails for reasons unrelated to its own diff — including #695, which only touchescrates/vcad-ecad-export/src/gerber.rs.Both were verified against
origin/maindirectly, not inferred from a PR run.1.
cargo fmt --check— the first step in the Rust job, so nothing after it ran:2.
cargo clippy -- -D warnings— the next gate, which the format failure was masking. Fixing only the formatting moved the red one step down the job, which is exactly what the first push of this PR showed:What
rustfmt --edition 2021overcrates/vcad-kernel-magnetostatic(9 files, 7 changed). No hand edits — every hunk is line-wrapping of a chained expression or a macro call.k % 2 == 0→k.is_multiple_of(2)inPolarity::alternating. Identical behaviour onusize.Verified locally, with CI's exact invocations
cargo clippy --workspace --exclude vcad-desktop --features vcad-kernel-text/no-builtin-font -- -D warnings→ clean. (Note CI does not pass--all-targets; with it, several unrelated crates have pre-existing test-only lints — out of scope here.)cargo test -p vcad-kernel-magnetostatic→ 20 passed.rustfmt --checkover the crate → clean.Kept separate from #695 deliberately: an unrelated formatting-and-lint sweep does not belong in a Gerber export fix, and this unblocks every open PR, not just that one.
🤖 Generated with Claude Code