Fix/price cache remove version bump - #175
Closed
luiv-engineer wants to merge 11 commits into
Closed
Conversation
…88994955437 Add Claude Code GitHub Workflow
planning/MARKET_DATA_DESIGN.md provides: - Complete architecture overview with visual diagrams - Full code snippets for all 8 market data modules - PriceUpdate dataclass and PriceCache implementation - Unified MarketDataSource interface - GBM simulator with Cholesky correlation - Massive API client with REST polling - SSE streaming endpoint design - FastAPI lifecycle integration patterns - Testing strategy and examples - Error handling and edge cases - Configuration reference and quick start This is a production-ready implementation guide for the entire market data subsystem supporting both simulator and Massive API. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WbZgSj3krrpXSbziX9GsEx
Add comprehensive market data backend design document
- Listens for @claude tags in issue creation and comments - Posts acknowledgment when triggered - Logs issue details for processing Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5vwKNMUcG9R3aojrMhUwj
Add GitHub Actions workflow for @claude mentions in issues
- Add pull-requests: write permission - Explicit GITHUB_TOKEN passing - Better logging and error handling - Improved response message Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5vwKNMUcG9R3aojrMhUwj
- Replace template literal with escaped newlines - Remove backtick syntax that was causing YAML parse error Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5vwKNMUcG9R3aojrMhUwj
Fix GitHub Actions workflow for @claude mentions
PriceCache.remove() silently dropped a ticker from the cache without incrementing the version counter that the SSE endpoint uses to decide when to push a new payload. Practical effect: removing the last tracked ticker (empty watchlist) froze the version counter forever, so already-connected SSE clients kept serving the stale, now-deleted ticker indefinitely; for the Massive source (15s+ poll interval) any removal lagged an extra poll cycle before disappearing from the stream. - cache.py: increment _version in remove(), guarded on whether a ticker was actually present so no-op removals don't trigger a wasted SSE push. - test_cache.py: add test_remove_increments_version and test_remove_nonexistent_does_not_bump_version. - planning/MARKET_DATA_REVIEW.md: comprehensive review of the market data backend (verifies prior review's fixes, full test/lint/coverage run, this bug's discovery + fix, and remaining recommendations). 75/75 tests pass, ruff clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ww15Nu9BvuE18N8zCFtGCW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.