Skip to content

Conversation

@technOslerphile
Copy link

The issue and the fix are both discussed here:

ISSUE 1068

@ed-donner
Copy link
Owner

Hey - many thanks again for this - before I merge it, would you be able to remove day2.ipynb from this and just leave the python module? Thanks so much

@technOslerphile
Copy link
Author

Hey - many thanks again for this - before I merge it, would you be able to remove day2.ipynb from this and just leave the python module? Thanks so much

Sure, Ed. It's done. Please check.

@ed-donner
Copy link
Owner

Ah actually no that wouldn't work - you can see that merging this PR would now actually delete day2 from the repo. You can see the "Files changed" tab to see the affect of merging the repo. The key is to remove changes to the file from the PR, rather than making a PR which deletes the file..

@technOslerphile
Copy link
Author

technOslerphile commented Dec 20, 2025

Ah actually no that wouldn't work - you can see that merging this PR would now actually delete day2 from the repo. You can see the "Files changed" tab to see the affect of merging the repo. The key is to remove changes to the file from the PR, rather than making a PR which deletes the file..

@ed-donner
Well, so my first intuition was right. I did feel like the merge would delete day2.ipynb in your repo, but since you asked me to "remove day2.ipynb" in your earlier comment, I thought there might be some "other mechanisms" in Git that would handle such changes. I am very new to this whole "pull request" thing. But at least my first intuition was right (that there are no such "other mechanisms") :)

I guess the new commit should work well. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants