Conversation
Contributor
Author
|
The changes made to the properties display mean that generated values (such as element dragging) are shown with full precision. Rounding these would need to be done when they are assigned to the path element since they just get stored as I also had to change the undo-history commands to take in unit values instead of numbers in order to preserve expressions when undo/redo occurs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces most numeric values with a unit aware record type. Note that the use of
structuredClonein the history saving logic means that storing the actualmathjs.Unitvalue is not possible. I have not modified the tests or file saving code yet, as this pr will eventually need breaking changes in the save file format.Right now this PR is very much a work in progress, but I wanted to share my current progress and get any feedback on the proposed changes.