[Help Wanted] feat: add cover flow to player #653
+471
−3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package com.cappielloantonio.tempo.factory; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import androidx.lifecycle.ViewModel; | ||
| import androidx.lifecycle.ViewModelProvider; | ||
|
|
||
| import com.cappielloantonio.tempo.repository.CoverRepository; | ||
| import com.cappielloantonio.tempo.viewmodel.CoverFlowViewModel; | ||
|
|
||
| public class CoverFlowViewModelFactory implements ViewModelProvider.Factory { | ||
|
|
||
| private final CoverRepository repository; | ||
|
|
||
| public CoverFlowViewModelFactory(@NonNull CoverRepository repository) { | ||
| this.repository = repository; | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public <T extends ViewModel> T create(@NonNull Class<T> modelClass) { | ||
| if (modelClass.isAssignableFrom(CoverFlowViewModel.class)) { | ||
| //noinspection unchecked | ||
| return (T) new CoverFlowViewModel(repository); | ||
| } | ||
| throw new IllegalArgumentException("Unknown ViewModel class"); | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package com.cappielloantonio.tempo.model; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import androidx.annotation.Nullable; | ||
|
|
||
| public class Cover { | ||
| private final String url; // image to show in the flow | ||
| private final String coverArtId; // id used by the CustomGlideRequest (may be null) | ||
|
|
||
| public Cover(@NonNull String url, @Nullable String coverArtId) { | ||
| this.url = url; | ||
| this.coverArtId = coverArtId; | ||
| } | ||
|
|
||
| @NonNull | ||
| public String getUrl() { | ||
| return url; | ||
| } | ||
|
|
||
| /** Returns the id that the CustomGlideRequest needs – can be null. */ | ||
| @Nullable | ||
| public String getCoverArtId() { | ||
| return coverArtId; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package com.cappielloantonio.tempo.repository; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import androidx.annotation.WorkerThread; | ||
| import androidx.media3.common.MediaMetadata; | ||
| import androidx.media3.session.MediaBrowser; | ||
|
|
||
| import com.cappielloantonio.tempo.model.Cover; | ||
| import com.google.common.util.concurrent.ListenableFuture; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| public interface CoverRepository { | ||
| /** Returns a list of covers. Call should be made off the UI thread. */ | ||
| @WorkerThread | ||
| List<Cover> getCovers() throws Exception; | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| package com.cappielloantonio.tempo.repository; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import androidx.annotation.WorkerThread; | ||
| import androidx.media3.common.MediaMetadata; | ||
| import androidx.media3.session.MediaBrowser; | ||
|
|
||
| import com.cappielloantonio.tempo.glide.CustomGlideRequest; | ||
| import com.cappielloantonio.tempo.model.Cover; | ||
| import com.google.common.util.concurrent.ListenableFuture; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Arrays; | ||
| import java.util.List; /** Example implementation that extracts data from a MediaBrowser */ | ||
| public class MediaBrowserCoverRepository implements CoverRepository { | ||
|
|
||
| private final ListenableFuture<MediaBrowser> mediaBrowserFuture; | ||
|
|
||
| public MediaBrowserCoverRepository(@NonNull ListenableFuture<MediaBrowser> mediaBrowserFuture) { | ||
| this.mediaBrowserFuture = mediaBrowserFuture; | ||
| } | ||
|
|
||
| @Override | ||
| @WorkerThread | ||
| public List<Cover> getCovers() throws Exception { | ||
| MediaBrowser mediaBrowser = mediaBrowserFuture.get(); // blocks only inside a background thread | ||
| MediaMetadata metadata = mediaBrowser.getMediaMetadata(); | ||
|
|
||
| // Inject this here, somehow, since it grabs the covertArtId | ||
| /*` | ||
| CustomGlideRequest.Builder | ||
| .from(requireContext(), metadata.extras.getString("coverArtId"), CustomGlideRequest.ResourceType.Song) | ||
| .build() | ||
| .into(bind.playerHeaderLayout.playerHeaderMediaCoverImage); | ||
|
|
||
| */ | ||
| // ----------------------------------------------------------------- | ||
| // Replace the below with the real extraction logic from metadata. | ||
| // For demonstration we just return the three dog‑image URLs. | ||
| // ----------------------------------------------------------------- | ||
| List<String> urls = Arrays.asList( | ||
| "https://images.dog.ceo/breeds/affenpinscher/n02110627_11858.jpg", | ||
| "https://images.dog.ceo/breeds/hound-english/n02089973_811.jpg", | ||
| "https://images.dog.ceo/breeds/shiba/shiba-14.jpg" | ||
| ); | ||
|
|
||
| List<Cover> covers = new ArrayList<>(); | ||
| for (String url : urls) { | ||
| covers.add(new Cover(url, null)); // coverArtId can be filled later if needed | ||
| } | ||
| return covers; | ||
|
Comment on lines
+27
to
+51
Contributor
There was a problem hiding this comment. Repository currently bypasses the playback source, so Cover Flow cannot sync with queue state. At Line 27 metadata is retrieved, but Lines 41-50 return a static dog URL list instead of mapping the actual playback/queue data. This breaks the intended data contract for end-to-end queue synchronization. Direction for fix- MediaMetadata metadata = mediaBrowser.getMediaMetadata();
- ...
- List<String> urls = Arrays.asList(...);
- List<Cover> covers = new ArrayList<>();
- for (String url : urls) {
- covers.add(new Cover(url, null));
- }
- return covers;
+ // Build covers from the active queue/media items so RecyclerView state
+ // and playback queue represent the same ordering/source of truth.
+ // (Use media item art URI and/or coverArtId extracted from metadata extras.)
+ return extractCoversFromQueue(mediaBrowser);🤖 Prompt for AI Agents |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| package com.cappielloantonio.tempo.ui.adapter; | ||
|
|
||
| import android.content.Context; | ||
| import android.view.LayoutInflater; | ||
| import android.view.View; | ||
| import android.view.ViewGroup; | ||
| import android.widget.ImageView; | ||
|
|
||
| import androidx.recyclerview.widget.RecyclerView; | ||
|
|
||
| import com.bumptech.glide.Glide; | ||
| import com.cappielloantonio.tempo.R; | ||
| import com.cappielloantonio.tempo.model.Cover; | ||
|
|
||
| import org.jspecify.annotations.NonNull; | ||
|
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify whether JSpecify is explicitly declared and how broadly it's used.
set -euo pipefail
echo "== Build files mentioning jspecify =="
rg -n --iglob '*gradle*' 'jspecify|org\.jspecify'
echo
echo "== Java/Kotlin files importing org.jspecify.annotations.NonNull =="
rg -n 'import\s+org\.jspecify\.annotations\.NonNull'
echo
echo "== Java/Kotlin files importing androidx.annotation.NonNull =="
rg -n 'import\s+androidx\.annotation\.NonNull'Repository: eddyizm/tempus Length of output: 96 🏁 Script executed: # Check if the file exists and read its imports
fd -n 'CoverFlowAdapter.java' --exec head -80 {}
echo "=== Checking for build files ==="
fd -t f -e gradle -e xml | grep -E '(build|pom)' | head -20Repository: eddyizm/tempus Length of output: 370 🏁 Script executed: # More comprehensive search for jspecify in the entire codebase
echo "== All files with jspecify anywhere in content =="
rg 'jspecify' -i
echo
echo "== All imports of NonNull annotations =="
rg 'import.*NonNull' -A 1Repository: eddyizm/tempus Length of output: 45111 🏁 Script executed: # Check main build.gradle files for dependencies
echo "=== app/build.gradle ==="
cat app/build.gradle | grep -A 100 "dependencies"
echo
echo "=== Root build.gradle ==="
head -100 build.gradleRepository: eddyizm/tempus Length of output: 3326 🏁 Script executed: # Check if jspecify appears anywhere in gradle files (even if commented)
echo "=== Any mention of jspecify in all gradle files ==="
rg 'jspecify' -i app/build.gradle build.gradle gradle.properties settings.gradle 2>/dev/null || echo "No jspecify found"
# Also check if CoverFlowAdapter.java and UIUtil.java are the ONLY files with jspecify imports
echo
echo "=== All lines mentioning jspecify in source files ==="
rg 'org\.jspecify' --type javaRepository: eddyizm/tempus Length of output: 405 Replace JSpecify is not declared as a dependency in the build configuration. This adapter and UIUtil.java are the only two files in the codebase using JSpecify annotations; all other files use AndroidX annotations. The inconsistency should be resolved by standardizing on 🤖 Prompt for AI Agents |
||
|
|
||
| import java.util.List; | ||
|
|
||
| public class CoverFlowAdapter extends RecyclerView.Adapter<CoverFlowAdapter.CoverViewHolder> { | ||
|
|
||
| /** Callback that is invoked for every bound item – useful for the extra Glide request. */ | ||
| public interface OnCoverBoundListener { | ||
| void onCoverBound(@NonNull Cover cover, @NonNull ImageView coverImage); | ||
| } | ||
|
|
||
| private final Context context; | ||
| private final List<Cover> covers; | ||
| private final OnCoverBoundListener boundListener; | ||
|
|
||
| public CoverFlowAdapter(@NonNull Context context, | ||
| @NonNull List<Cover> covers, | ||
| @NonNull OnCoverBoundListener boundListener) { | ||
| this.context = context; | ||
| this.covers = covers; | ||
| this.boundListener = boundListener; | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public CoverViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) { | ||
| // Inflate a simple item layout that contains only an ImageView. | ||
| View view = LayoutInflater.from(context).inflate(R.layout.item_cover_flow, parent, false); | ||
| return new CoverViewHolder(view); | ||
| } | ||
|
|
||
| @Override | ||
| public void onBindViewHolder(@NonNull CoverViewHolder holder, int position) { | ||
| Cover cover = covers.get(position); | ||
| holder.bind(cover); | ||
| // Let the fragment (or caller) run the extra CustomGlideRequest if it needs the id. | ||
| boundListener.onCoverBound(cover, holder.coverImage); | ||
| } | ||
|
Comment on lines
+47
to
+52
Contributor
There was a problem hiding this comment. Avoid issuing two image loads for the same bind target.
Suggested fix- Cover cover = covers.get(position);
- holder.bind(cover);
- // Let the fragment (or caller) run the extra CustomGlideRequest if it needs the id.
- boundListener.onCoverBound(cover, holder.coverImage);
+ Cover cover = covers.get(position);
+ // Use one source-of-truth load path per item.
+ if (cover.getCoverArtId() != null) {
+ boundListener.onCoverBound(cover, holder.coverImage);
+ } else {
+ holder.bind(cover);
+ }Also applies to: 70-75 🤖 Prompt for AI Agents |
||
|
|
||
| @Override | ||
| public int getItemCount() { | ||
| return covers.size(); | ||
| } | ||
|
|
||
| /** ----------------------------------------------------------------- | ||
| * ViewHolder – each item holds a single ImageView. | ||
| * ----------------------------------------------------------------- */ | ||
| class CoverViewHolder extends RecyclerView.ViewHolder { | ||
| final ImageView coverImage; | ||
|
|
||
| CoverViewHolder(@NonNull View itemView) { | ||
| super(itemView); | ||
| coverImage = itemView.findViewById(R.id.item_cover_image); | ||
| } | ||
|
|
||
| void bind(@NonNull Cover cover) { | ||
| // Normal image loading (the flow thumbnails) | ||
| Glide.with(context) | ||
| .load(cover.getUrl()) | ||
| .centerCrop() | ||
| .into(coverImage); | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a bounded wait when resolving
mediaBrowserFuture.Line 26 uses
mediaBrowserFuture.get()with no timeout; if the future never resolves, cover loading can hang indefinitely and never post data.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents