Fallback to random track if getsimilar returns empty#728
Conversation
|
One problem with continuous play is excessive filling of queue, especially with a small library. These two approaches are not incompatible. |
|
Actually, I'm not a big fan of sending random tracks instead of similar songs. Perhaps we could add a "Random Fallback" preference, just below Continuous play option? |
|
We need to think about this as @MaFo-28 said, it is very jarring to have it do something unexpected. I actually tried this in the not so distance past when I refactored a bunch of the play stuff and let me tell you, it was a disaster. Of course, most of it was due to my flawed implementation but even if it had worked as expected, it would still be sketch. I like the preference - I think with the other PR, we could make this a section. The discovery section kinda works this way already as a random feature. |
|
Thank you for the feedbacks, I'll update the PR to include a preference in the option menu. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @spicyPoke |

Hi, I found that for some tracks that lack similarities with other tracks, Tempus will not add any track into the current queue when continuous play is active.
My proposal was to fallback to random tracks so it will continue playing regardless.
This PR make
getContinuousMixusegetSimilarSongs2as the main functionality and fallback togetSimilarSongsif that fail. After that the result of it is filtered against the current queue, if it returns empty then we fallback to random 25 songs.