fix: deep-linked playlist loads no songs and crashes from null id (#729)

[herrerad85]

Fixes #729.

Problem

Opening a playlist by id — e.g. a tempo://asset/playlist/<id> deep link from
Tasker — shows the playlist's metadata but never its songs (endless spinner),
then crashes after a minute or two.

Root cause

PlaylistWithSongs (the type the Subsonic getPlaylist response deserializes
into) annotated its id with @SerializedName("_id"), but the API sends id.
The _id was a workaround for Gson's "declares multiple JSON fields named 'id'"
error (the property shadows Playlist.id), but it left the id null. The page
then re-fetched the songs with a null id; Retrofit drops the null @Query("id"),
the server replies error 10: missing parameter: 'id', and the song list spins
forever behind a misleading "Playlist not found" dialog. The null id is also what
produces the reported String.equals NPE. Opening a playlist from the in-app
list works because the list endpoint deserializes the base Playlist, which maps
id correctly.

Fix

• PlaylistWithSongs no longer redeclares id; it inherits Playlist.id, which
  maps id correctly. The value still survives @Parcelize (the base class is
  @Parcelize too), and a secondary constructor keeps the local "all songs" use.
• Caching a deep-linked playlist's songs then hit a FOREIGN KEY constraint,
  because the single-playlist endpoint never inserts the playlist row (only the
  full-list path does, via cacheAllPlaylists). cachePlaylistSongs now inserts
  the parent first, via a new insertIfAbsent (IGNORE) so it can't
  delete-replace a row that already has child songs.

Testing

Verified on an android-35 emulator against the Navidrome public demo:

• Before: deep link → metadata shown, songs spinner forever, "Playlist not found"
  dialog, then crash.
• After: deep link loads metadata, cover art and the full song list; no crash,
  no FK violation, no false "not found"; back-to-back deep links to two different
  playlists both succeed.

Builds successfully on the development toolchain (Gradle 9.4.1 / AGP 9.2.1).

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b5cf58a-6d8c-40f2-8499-23341b1d4490

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

❌ Error creating Unit Test PR.
❌ Error creating Unit Test PR.

• Create PR with unit tests
• Commit unit tests in branch fix/playlist-deeplink-null-id

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.

[coderabbitai]

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.

[coderabbitai]

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.

[coderabbitai]

❌ Failed to create PR with unit tests: AGENT_CHAT: Failed to open pull request

[coderabbitai]

❌ Failed to create PR with unit tests: AGENT_CHAT: Failed to open pull request

[coderabbitai]

❌ Failed to create PR with unit tests: AGENT_CHAT: Failed to open pull request