fix sceneloader for build compatibility; refactor#55
Open
eioe wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes SceneLoader build compatibility by ensuring UnityEditor-only APIs are guarded behind #if UNITY_EDITOR, while also refactoring the scene load/unload logic with extra safety checks.
Changes:
- Wrapped
UnityEditorusage in#if UNITY_EDITORand switched the editor-only reference field toSceneAsset. - Refactored load/unload methods to add guard clauses and handle already-loaded / unload failure cases.
- Moved initial load behavior to call
LoadScene(_sceneName)fromAwake().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
thefirstfloor
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue at build time -> closes #47
some cosmetic refactoring / safety checks.
tested in Editor and local build. (Load() and Unload(). )