fix: pass codename in apt dispatch payload#34
Merged
Conversation
reprepro requires a distribution codename to know which suite to add the package to. The dispatch payload was missing this field, causing 'Cannot find definition of distribution' and a silent failure. Extract the codename from debian/changelog via dpkg-parsechangelog and include it as client_payload.codename in the repository_dispatch call. Also add -f to curl so a non-2xx response fails the job loudly instead of silently succeeding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apt dispatch payload was missing the
codenamefield, causing reprepro to fail withCannot find definition of distribution ''. The job still reported success becausecurl -ssuppressed the error output.Root cause:
build-deb.ymlsentdeb_urlandpackagebut nevercodename. The apt repo workflow passes that field straight toreprepro includedeb $CODENAME, which requires it.Fix:
debian/changelogviadpkg-parsechangelog --show-field Distribution(already available from the installed build deps) and add it asclient_payload.codenamein the dispatch payload.-fto thecurlcall so a non-2xx response actually fails the job instead of silently passing.