fix: move format_ip definition above --quick-add block#35
Merged
Conversation
format_ip() was defined after the --quick-add early-exit block, so calling it from --quick-add resulted in 'format_ip: not found'. Move it up to just before the _norm_flag block, where it is available to both the quick-add path and the main run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_ip()was defined after the--quick-addearly-exit block, so invokingpostallow -q <domain>hitformat_ip: not foundand aborted.Move the function definition up to just before the
_norm_flagblock, where it is available to both the quick-add path and the main run. No behaviour change for the normal full run.